Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in metric tensor elements #628

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Fix bug in metric tensor elements #628

merged 1 commit into from
Aug 18, 2023

Conversation

unalmis
Copy link
Collaborator

@unalmis unalmis commented Aug 18, 2023

Fix bugs in g^rt_r and g^rz_r and maybe others.
Changes are just copied from github pull request #556

One bug on master is that

* dot(data["e^theta"], cross(data["e_zeta"], data["e_zeta_r"]))
should be
$$e_{\theta} \times \partial_{\rho} e_{\zeta}$$
There might be more bugs on master, but I stopped looking after I found the above because they should be corrected by the changes in this PR.

Fix bugs in g^rt_r and g^rz_r and maybe others.
Changes are just copied from github pull request #556
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #628 (ef064ee) into master (6b366f5) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #628      +/-   ##
==========================================
+ Coverage   94.37%   94.38%   +0.01%     
==========================================
  Files          77       77              
  Lines       17898    17898              
==========================================
+ Hits        16891    16893       +2     
+ Misses       1007     1005       -2     
Files Changed Coverage Δ
desc/compute/_metric.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@unalmis unalmis merged commit 9e72894 into master Aug 18, 2023
21 checks passed
@unalmis unalmis deleted the metric_tensor_bugfix branch August 18, 2023 16:06
@unalmis unalmis added the bug fix Something was fixed label Jul 22, 2024
@unalmis unalmis self-assigned this Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Something was fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants