Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JAX implementation of
REGCOIL
algorithm and Add Ability to Discretize Current Potentials into Coilsets #579base: master
Are you sure you want to change the base?
Add JAX implementation of
REGCOIL
algorithm and Add Ability to Discretize Current Potentials into Coilsets #579Changes from 14 commits
648bcc0
c1cb228
eb32057
a253a86
71a7a24
d1f8122
057f5db
e58715b
ba2a122
333baa5
846495b
72e88ce
c5a287b
6388362
6e789de
857b418
4164e15
216314f
3ae17ba
979a6a7
86f5665
d8efb23
926af54
c5e1cd7
335c241
cfac90a
2612b8e
274e823
87654f3
bc066c5
736991c
cd3b35c
ce55d74
119d036
d838330
9bfb282
b254db1
83dc2ae
739773d
7136f8d
60753d9
61c6dff
fef55b2
5277f61
7a03147
8dc06d9
e9c116d
a3e8ec7
49fdd6c
524b6d3
0c838f9
0e195da
28d227a
4a98c7e
c82a758
fd8a5d5
3acbff4
151c0b6
0ec3bdb
148c2dd
676ff7e
f7d2517
5c9b2a0
f00c098
7ad397e
f9b7019
f977f72
a482be0
c74e19f
ba2cb86
dac67c7
93c5d87
335299b
7edafe4
c26ab10
079ea30
eb584b4
98be741
7ec01f8
bbfe336
c97d6fd
3d9a932
3d4296a
c135f40
0707d58
610da80
4a538c2
46c2a17
6ea87fe
71c83fc
8c06a11
4ab1c0d
18c3cc4
2872778
80c5a91
48316fe
a47457f
edf7fe2
7cbe46e
72451c2
87cf4ce
7c90148
c4d21c5
57c071e
5411559
7d5fd86
6e273cb
8ad2103
8a52460
349dc05
ce49884
3559474
aed4c80
4ab27ff
8adb311
4580947
7584538
0fc8c87
955bb5d
7e0620f
165c9fb
09aa8db
8170038
afee0bb
9831549
e9e8f6f
9e34982
5d1c947
66cc809
3a2caea
7f28ad5
19906e1
30300ae
b5b9ef3
325830f
482eecc
7fab1fc
b23e997
09d7f6c
febcec3
4f02f07
921547a
a258dce
510f609
ce36f11
499ca9b
a548032
6412936
1543b59
afed2f1
3938484
b6a0525
0f0a1ea
cc913ba
5b9a855
4445e9f
342aea6
7d2c173
2ba168c
725815a
ff65cbe
c165bf3
0d96661
e6bab25
89ee374
65ba0e8
c173357
45b7ca7
9bb9b2b
78e3eca
75b0de4
d515e2a
63f0ed7
56f848f
e75ce64
688ec6c
ecf36bc
06215c5
1a49dec
4797dea
0b1c77c
9b7cdf4
c29fe2a
a25465f
9f33691
5761bdb
8a15000
d0a3c15
b647b00
4e7cc7e
2812ae7
f0ad61b
7cd0c5b
65ce96a
f90582a
77e237b
c211a5f
2dc266c
dfe1d1c
a91fe2a
069ecad
2e8e35f
2beb620
40f6555
3ca79f3
c4ba607
e8ce8d7
a60c276
169f03a
32f9bd7
d523a06
5474e54
373d0c1
950582a
8ec81d4
38ae106
6ee875e
32a7d90
2f57857
6100497
4f976e8
bea645d
037e49d
c5620d3
1d4d20a
68373fe
b2e90bc
e513df2
967a580
c2b3436
2ff2065
80f6f33
4d8c56a
c07c893
5fd7a05
66b560a
193182e
fa1caa0
b202a5e
6e738ea
baf9dfc
8a70f31
192fb8a
7a64752
f2873e2
91c33cd
e6d85be
8118fe7
6f571e1
59cb549
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [flake8] <402> reported by reviewdog 🐶
module level import not at top of file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[flake8] <401> reported by reviewdog 🐶
'jax.grad' imported but unused
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[flake8] <401> reported by reviewdog 🐶
'jax.jit' imported but unused
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[flake8] <401> reported by reviewdog 🐶
'jax.vmap' imported but unused
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [flake8] <402> reported by reviewdog 🐶
module level import not at top of file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[flake8] <401> reported by reviewdog 🐶
'scipy.interpolate.interp1d' imported but unused
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [flake8] <402> reported by reviewdog 🐶
module level import not at top of file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[flake8] <401> reported by reviewdog 🐶
'desc.coils.Coil' imported but unused
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[flake8] <401> reported by reviewdog 🐶
'desc.coils.FourierPlanarCoil' imported but unused
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[flake8] <401> reported by reviewdog 🐶
'desc.coils.XYZCoil' imported but unused
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [flake8] <402> reported by reviewdog 🐶
module level import not at top of file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[flake8] <401> reported by reviewdog 🐶
'desc.equilibrium.EquilibriaFamily' imported but unused
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[flake8] <401> reported by reviewdog 🐶
'desc.equilibrium.Equilibrium' imported but unused
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [flake8] <402> reported by reviewdog 🐶
module level import not at top of file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[flake8] <401> reported by reviewdog 🐶
'desc.magnetic_fields.SumMagneticField' imported but unused
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[flake8] <401> reported by reviewdog 🐶
'desc.magnetic_fields.ToroidalMagneticField' imported but unused
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [flake8] <402> reported by reviewdog 🐶
module level import not at top of file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[flake8] <401> reported by reviewdog 🐶
'desc.plotting.plot_1d' imported but unused
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[flake8] <401> reported by reviewdog 🐶
'desc.plotting.plot_2d' imported but unused
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[flake8] <401> reported by reviewdog 🐶
'desc.plotting.plot_comparison' imported but unused
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[flake8] <401> reported by reviewdog 🐶
'desc.plotting.plot_surfaces' imported but unused
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [flake8] <402> reported by reviewdog 🐶
module level import not at top of file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[flake8] <401> reported by reviewdog 🐶
'utils.get_coilset_from_MAKEGRID_or_regcoil' imported but unused
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [flake8] <402> reported by reviewdog 🐶
module level import not at top of file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[flake8] <811> reported by reviewdog 🐶
redefinition of unused 'os' from line 6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [flake8] <402> reported by reviewdog 🐶
module level import not at top of file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [flake8] <501> reported by reviewdog 🐶
line too long (119 > 88 characters)