Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stability hotfix #266

Merged
merged 6 commits into from
Sep 22, 2022
Merged

Stability hotfix #266

merged 6 commits into from
Sep 22, 2022

Conversation

unalmis
Copy link
Collaborator

@unalmis unalmis commented Sep 21, 2022

Fix derivative of abs(sqrt(g)) computation.

  • Bug found by Dr. Matt Landreman
  • Affected quantities are V_rr(r), D_well, D_Mercier, magnetic well

For documentation, stability compute function results for dshape are below. There were no visible differences for heliotron.

Old:
old_dshape

Notably, the dip near the boundary is gone.
new_dshape

- Bug found by Dr. Matt Landreman
- Affected quantities are V_rr(r), D_well, D_Mercier, magnetic well
@unalmis
Copy link
Collaborator Author

unalmis commented Sep 21, 2022

I suggest merging this and #251 now. We can tighten stability function tolerances in #261 as that is one of its goals. Tolerances are not tightened here because this branch lacks certain grid fixes.

@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Base: 90.99% // Head: 90.99% // No change to project coverage 👍

Coverage data is based on head (fb92bc3) compared to base (9a065a7).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #266   +/-   ##
=======================================
  Coverage   90.99%   90.99%           
=======================================
  Files          56       56           
  Lines       11840    11840           
=======================================
  Hits        10774    10774           
  Misses       1066     1066           
Impacted Files Coverage Δ
desc/equilibrium.py 89.32% <ø> (ø)
desc/perturbations.py 84.87% <ø> (ø)
desc/compute/_core.py 97.46% <100.00%> (ø)
desc/compute/_stability.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

f0uriest
f0uriest previously approved these changes Sep 21, 2022
Copy link
Member

@f0uriest f0uriest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

dpanici
dpanici previously approved these changes Sep 22, 2022
Copy link
Collaborator

@dpanici dpanici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@unalmis unalmis dismissed stale reviews from dpanici and f0uriest via fb92bc3 September 22, 2022 00:40
@unalmis unalmis merged commit 91fefa2 into master Sep 22, 2022
@unalmis unalmis deleted the stability_hotfix branch September 22, 2022 01:42
@unalmis unalmis added the bug fix Something was fixed label Jul 22, 2024
@unalmis unalmis self-assigned this Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Something was fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants