-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stability hotfix #266
Stability hotfix #266
Conversation
- Bug found by Dr. Matt Landreman - Affected quantities are V_rr(r), D_well, D_Mercier, magnetic well
Codecov ReportBase: 90.99% // Head: 90.99% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #266 +/- ##
=======================================
Coverage 90.99% 90.99%
=======================================
Files 56 56
Lines 11840 11840
=======================================
Hits 10774 10774
Misses 1066 1066
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Fix derivative of abs(
sqrt(g)
) computation.V_rr(r)
,D_well
,D_Mercier
,magnetic well
For documentation, stability compute function results for dshape are below. There were no visible differences for heliotron.
Old:
Notably, the dip near the boundary is gone.