Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing unit test markers #1305

Merged
merged 6 commits into from
Oct 17, 2024
Merged

Add missing unit test markers #1305

merged 6 commits into from
Oct 17, 2024

Conversation

dpanici
Copy link
Collaborator

@dpanici dpanici commented Oct 16, 2024

  • Adds missing unit test labels for some tests.
  • Adds a precommit hook that checks tests folder and warns the user if a test without mark is added

@dpanici dpanici added the easy Short and simple to code or review label Oct 16, 2024
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.51%. Comparing base (ebb3a69) to head (cd90a6a).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1305      +/-   ##
==========================================
+ Coverage   94.48%   95.51%   +1.03%     
==========================================
  Files          96       96              
  Lines       23975    23975              
==========================================
+ Hits        22652    22900     +248     
+ Misses       1323     1075     -248     
Files with missing lines Coverage Δ
desc/objectives/objective_funs.py 94.75% <ø> (+0.13%) ⬆️

... and 21 files with indirect coverage changes

@dpanici dpanici requested review from a team, rahulgaur104, f0uriest, ddudt, kianorr, sinaatalay, unalmis and YigitElma and removed request for a team October 16, 2024 16:44
unalmis
unalmis previously approved these changes Oct 16, 2024
rahulgaur104
rahulgaur104 previously approved these changes Oct 16, 2024
@f0uriest
Copy link
Member

We should add a pre commit check to make sure this doesn't keep happening

@YigitElma
Copy link
Collaborator

We should add a pre commit check to make sure this doesn't keep happening

I can try to add this in this PR or some other one

@f0uriest f0uriest dismissed stale reviews from unalmis and rahulgaur104 via 8563b6d October 16, 2024 19:23
Copy link
Contributor

github-actions bot commented Oct 16, 2024

|             benchmark_name             |         dt(%)          |         dt(s)          |        t_new(s)        |        t_old(s)        | 
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
 test_build_transform_fft_midres         |     -1.13 +/- 4.99     | -6.90e-03 +/- 3.05e-02 |  6.04e-01 +/- 2.1e-02  |  6.11e-01 +/- 2.2e-02  |
 test_build_transform_fft_highres        |     +1.73 +/- 5.32     | +1.71e-02 +/- 5.26e-02 |  1.01e+00 +/- 3.4e-02  |  9.89e-01 +/- 4.0e-02  |
 test_equilibrium_init_lowres            |    +13.04 +/- 12.25    | +4.85e-01 +/- 4.56e-01 |  4.21e+00 +/- 4.5e-01  |  3.72e+00 +/- 2.7e-02  |
 test_objective_compile_atf              |     +4.54 +/- 4.77     | +3.57e-01 +/- 3.75e-01 |  8.22e+00 +/- 3.1e-01  |  7.86e+00 +/- 2.2e-01  |
 test_objective_compute_atf              |     +2.62 +/- 3.27     | +2.72e-04 +/- 3.40e-04 |  1.07e-02 +/- 3.1e-04  |  1.04e-02 +/- 1.4e-04  |
 test_objective_jac_atf                  |     +1.10 +/- 3.31     | +2.13e-02 +/- 6.39e-02 |  1.95e+00 +/- 2.8e-02  |  1.93e+00 +/- 5.7e-02  |
 test_perturb_1                          |     +5.55 +/- 2.41     | +6.90e-01 +/- 3.00e-01 |  1.31e+01 +/- 1.8e-01  |  1.24e+01 +/- 2.4e-01  |
 test_proximal_jac_atf                   |     +1.35 +/- 0.83     | +1.09e-01 +/- 6.70e-02 |  8.19e+00 +/- 4.4e-02  |  8.08e+00 +/- 5.0e-02  |
 test_proximal_freeb_compute             |     -0.69 +/- 0.78     | -1.27e-03 +/- 1.44e-03 |  1.83e-01 +/- 1.3e-03  |  1.85e-01 +/- 5.3e-04  |
 test_build_transform_fft_lowres         |     +1.72 +/- 4.96     | +8.90e-03 +/- 2.56e-02 |  5.25e-01 +/- 2.5e-02  |  5.16e-01 +/- 7.4e-03  |
 test_equilibrium_init_medres            |     +0.68 +/- 1.33     | +2.78e-02 +/- 5.42e-02 |  4.12e+00 +/- 4.5e-02  |  4.09e+00 +/- 3.1e-02  |
 test_equilibrium_init_highres           |     +0.32 +/- 0.87     | +1.73e-02 +/- 4.72e-02 |  5.48e+00 +/- 3.9e-02  |  5.46e+00 +/- 2.6e-02  |
 test_objective_compile_dshape_current   |     -0.19 +/- 0.85     | -7.29e-03 +/- 3.29e-02 |  3.85e+00 +/- 3.0e-02  |  3.86e+00 +/- 1.3e-02  |
 test_objective_compute_dshape_current   |     +0.96 +/- 1.61     | +3.41e-05 +/- 5.72e-05 |  3.59e-03 +/- 3.1e-05  |  3.56e-03 +/- 4.8e-05  |
 test_objective_jac_dshape_current       |     -2.66 +/- 7.32     | -1.09e-03 +/- 3.01e-03 |  4.00e-02 +/- 2.5e-03  |  4.11e-02 +/- 1.6e-03  |
 test_perturb_2                          |     -0.02 +/- 1.03     | -4.09e-03 +/- 1.81e-01 |  1.76e+01 +/- 8.1e-02  |  1.76e+01 +/- 1.6e-01  |
 test_proximal_freeb_jac                 |     -1.51 +/- 1.45     | -1.14e-01 +/- 1.09e-01 |  7.42e+00 +/- 7.2e-02  |  7.53e+00 +/- 8.2e-02  |
 test_solve_fixed_iter                   |     -0.12 +/- 59.28    | -6.15e-03 +/- 2.96e+00 |  4.99e+00 +/- 2.1e+00  |  4.99e+00 +/- 2.1e+00  |

@dpanici dpanici merged commit 5d29342 into master Oct 17, 2024
24 checks passed
@dpanici dpanici deleted the dp/hotfix-quadflux-test branch October 17, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy Short and simple to code or review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants