-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
signed curvature #1085
Merged
Merged
signed curvature #1085
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
72195f8
initial commit
daniel-dudt 572766a
Merge branch 'yge/rpz2xyz' into dd/curvature
daniel-dudt 10ff1d9
Merge branch 'yge/rpz2xyz' into dd/curvature
daniel-dudt fc4bbf6
fix formulas
daniel-dudt bc3f2b9
Merge branch 'yge/rpz2xyz' into dd/curvature
ddudt 3a768d3
Merge branch 'yge/rpz2xyz' into dd/curvature
dpanici 50bea28
Merge branch 'yge/rpz2xyz' into dd/curvature
ddudt d6d4b4b
fix bug and test for compute center
daniel-dudt 64f48fb
Merge branch 'master' into dd/curvature
ddudt 9c4b3b1
Merge branch 'master' into dd/curvature
ddudt 9591eb2
debugging curvature sign
daniel-dudt fe0d15b
Merge branch 'master' into dd/curvature
ddudt bc38b60
fix bug in center computations
daniel-dudt 9a6e278
update test even though it doesn't really matter
daniel-dudt 6715aef
make the code more readable
daniel-dudt e8b95aa
Merge branch 'master' into dd/curvature
ddudt 5fa3338
fixing tests
daniel-dudt abc4a42
test frenet in xyz basis
daniel-dudt 2c4ad5c
consistent naming convention of coil/coils
daniel-dudt ca62ef1
fix bug in coil objective build order
daniel-dudt f293c62
generalize LinearObjectiveFromUser to work with OptimizableCollection
daniel-dudt a40ea3b
remove unused code
daniel-dudt 8801c4d
fix coil kwargs in tests
daniel-dudt 6fe0663
Merge branch 'master' into dd/curvature
ddudt da23cc4
making requested changes
daniel-dudt 12465c1
clarify CoilCurvature sign convention in docs
daniel-dudt 5ed70e0
update master compute data, again
daniel-dudt fc5d105
fix test
dpanici File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this work for a nested coilset?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should, because num_coils will just get called recursively until the self is a single coilset