This repository has been archived by the owner on Jan 16, 2024. It is now read-only.
reactivated the old loading indicator #1854
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@haideralishah what is your opinion about this? Have you removed the old loading indicator intentionally or accidentally for indicating API calls? |
|
@norbertschuler I'd recommend to phase out this, and instead use the in tab loader @haideralishah has implemented. There are instances where this comes on top of the new loader. I think we should identify places and Haider can implement it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1837
Should we bring back the old loading indicator for API queries for our native apps?