-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release: Refactor Project Details map for performance & other improvements #2082
Conversation
Refactors map for better performance while showing a single project
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, works in the deployment.
…ct, file formatting
- resets selectedSite to 0 while entering project details page - checks that sites exist for a project before calling zoomToProjectSite
…-issues Fix: Polygon Zoom Issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From time to time I still experience the zoom of Yucatan not working, but only showing this image below, but as it works better than before I vote to merge this and continue improving from this version:
Also there is still the issue that you can not bookmark and navigate to another site as the default one of a project, e.g. https://dev.pp.eco/de/yucatan?site=site_kLaHJavm46a4niH will always show https://dev.pp.eco/de/yucatan?site=site_ybVo0Vn007jQl56 - but that also is another issue to solve in pages/sites/[slug]/[p].tsx as I tried e.g. in #2014.
Also you cannot always bookmark and navigate to single ploc, e.g. https://dev.pp.eco/de/yucatan?ploc=NOSJZ7 - also another issue to solve separately.
Is this MR replacing #2050? |
Yes, that isn't needed anymore. Will close it. |
(use only more on leaderboard page)
…_twitter_link_from_footer removed twitter link from footer
Includes
This release makes the map functionality more stable by