Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 linter for plansys2_pddl_parser #327

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Conversation

Rezenders
Copy link
Contributor

  1. Activated linter for plansys2_pddl_parser
  2. Changed the extension of plansys2_pddl_parser header files from .h to .hpp
  3. Added copyright information to all files
  4. Formatted files with ament_clang_format --reformat
  5. Formatted files with ament_uncrustify --reformat
  6. Manually fixed remaining style errors
  7. Added // NOLINT to lines Ground.cpp#L34 and Ground.cpp#L72 as there is a conflict between cpplint and uncrustify (check Cannot satisfy both cpplint and uncrustify ament/ament_lint#158)

@Rezenders
Copy link
Contributor Author

@fmrico ready for review

@fmrico
Copy link
Contributor

fmrico commented Oct 2, 2024

LGTM, I have been reviewing since you created the PR. It is personally useful the great you made here including in the style tests this package. I don't know when it went out of the coverage of the tests, but what really matters is that now it is fixed.
Thanks @Rezenders

Of course, merging!! 🚀

@fmrico fmrico merged commit e2fd96e into PlanSys2:rolling Oct 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants