Initial wasm commit including pxr/base #3469
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add support for building pxr/base with Emscripten Test can be run using ctest with the result: 79% tests passed, 22 tests failed out of 106 Some details about the failed tests: | Test Name | Error Message | |----------------------------------|--------------------------------------------------------------------| | testArchAbi | Dynamic library limitation | | testArchFileSystem | Problem creating a file due to environment | | testArchStackTrace | Problem creating a file due to environment | | testArchSymbols | Dynamic library limitation | | testArchSystemInfo | Problem accessing a file in filesystem due to environment | | TfAtomicOfstreamWrapper | Cannot create a log file | | TfDl | Dynamic library limitation | | TfEnvSetting | Error: return code 7 doesn't match expected 0 (EXPECTED_RETURN_CODE)| | TfException | Throws but it is not caught | | TfFileUtils | Cannot create a log file | | TfPathUtils | Assumes preloaded files | | TfPointerAndBits | Issue with 32 bits architecture | | TfSafeOutputFile | Issues accessing filesystem | | testJsIO_PlugInfo | Fails because it cannot read the baseline | | testJsIO_Values | Fails because it cannot read the baseline | | testJsIO_Errors_BadCommaPlacement| Cannot open json file | | testJsIO_Errors_MismatchedBraces | Cannot open json file | | testJsConverter | Fails because it cannot read the baseline | | testJsWriter | Fails because it cannot read the baseline | | testJsWriter_Pretty | Fails because it cannot read the baseline | | testWorkThreadLimitsRawTBBMax | | | testWorkThreadLimitsRawTBB2 | | The change in pxr/base/arch/attributes.h was required since static constructors dont support parameters with an error `wasm-ld: error: constructor functions cannot take arguments: _Tf_RegistryAdd91(RegRegistry*)`
|
Filed as internal issue #USD-10518 ✅ CLA on file (This is an automated message. See here for more information.) |
|
/AzurePipelines run |
|
Pull request contains merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Test can be run using ctest with the result:
79% tests passed, 22 tests failed out of 106
Some details about the failed tests:
The change in pxr/base/arch/attributes.h was required since static constructors dont support parameters with an error
wasm-ld: error: constructor functions cannot take arguments: _Tf_RegistryAdd91(RegRegistry*)Checklist
[ X ] I have created this PR based on the dev branch
[ X ] I have followed the coding conventions
[ ] I have added unit tests that exercise this functionality (Reference:
testing guidelines)
[ ] I have verified that all unit tests pass with the proposed changes
[ X ] I have submitted a signed Contributor License Agreement (Reference:
Contributor License Agreement instructions)