Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autodesk: Add DIFF_COMPARE_OPTIONS to pxr_register_test() #3409

Open
wants to merge 1 commit into
base: feature-hgi-vulkan
Choose a base branch
from

Conversation

erikaharrison-adsk
Copy link
Contributor

Description of Change(s)

⚠ Branched off feature-hgi-vulkan

  • Add DIFF_COMPARE_OPTIONS to pxr_register_test(), and always use diff in testWrapper.py
    • Windows fc doesn't support the options used by some tests, so we need to switch to diff if we want to enable these tests on Windows.
    • Add logic to find diff on Windows, working of the fact that git will most surely be installed, and it comes with it.

Link to proposal (if applicable)

  • N/A

Fixes Issue(s)

  • N/A

Checklist

[ ] I have created this PR based on the dev branch

[X] I have followed the coding conventions

[ ] I have added unit tests that exercise this functionality (Reference:
testing guidelines)

[X] I have verified that all unit tests pass with the proposed changes

[X] I have submitted a signed Contributor License Agreement (Reference:
Contributor License Agreement instructions)

@jesschimein
Copy link
Contributor

Filed as internal issue #USD-10413

@jesschimein
Copy link
Contributor

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants