usdUtils: CompressionValidator #3400
Conversation
| @@ -104,11 +104,54 @@ _PackageEncapsulationValidator(const UsdStagePtr& usdStage) { | |||
| return errors; | |||
| } | |||
|
|
|||
| static | |||
| UsdValidationErrorVector | |||
| _CompressionValidator(const UsdStagePtr& usdStage) { | |||
There was a problem hiding this comment.
@tallytalwar I've come across something in this validator that's not clear to me.
My expectation from reading the description from the existing CompressionChecker is that this test should make sure that files within the USDZ file itself were not compressed. So I've created a sample file like this (in this repo as compressedUsdaInside.usdz). However this file fails here, before it can get to the usdchecker code.
If I try a different approach of compressing the usdz itself, it also fails early here.
Do you know how to reproduce the nicer errors from usdchecker itself?
There was a problem hiding this comment.
Also wanted to ping @dgovil to see if maybe he has an example of a failing CompressionChecker file, or ByteAlignmentChecker file. As I think I have the code for both of these validators, but am not sure how to get a test file that produces the error in usdchecker as of the latest release.
|
Filed as internal issue #USD-10398 |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Description of Change(s)
Link to proposal (if applicable)
Fixes Issue(s)
Checklist
[X] I have created this PR based on the dev branch
[X] I have followed the coding conventions
[ ] I have added unit tests that exercise this functionality (Reference:
testing guidelines)
[ ] I have verified that all unit tests pass with the proposed changes
[X] I have submitted a signed Contributor License Agreement (Reference:
Contributor License Agreement instructions)