Google Drive: Download File action bug fix #17055
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe changes update the Google Drive download file action to fix the export format options mapping, ensuring all options are returned as objects with Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant DownloadFileAction
participant ExportFormats
User->>DownloadFileAction: Selects Conversion Format
DownloadFileAction->>ExportFormats: Requests available formats
ExportFormats-->>DownloadFileAction: Returns array of {value, label} objects
DownloadFileAction-->>User: Presents consistent format options
Assessment against linked issues
Assessment against linked issues: Out-of-scope changesNo out-of-scope changes found. Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
components/google_drive/actions/download-file/download-file.mjs (1)
82-88: Ensure consistent object return for MIME type options
Switching the fallback to always return{ value, label }objects solves the bifurcation between strings and objects. Consider enhancing the fallback label—for example, derive a human-friendly name from the MIME type string—so end users see clearer option labels.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (3)
components/google_drive/actions/download-file/download-file.mjs(2 hunks)components/google_drive/actions/google-workspace-export-formats.mjs(2 hunks)components/google_drive/package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: pnpm publish
- GitHub Check: Lint Code Base
- GitHub Check: Publish TypeScript components
- GitHub Check: Verify TypeScript components
🔇 Additional comments (3)
components/google_drive/actions/google-workspace-export-formats.mjs (1)
90-97: Add Markdown Export Formats
You’ve correctly expanded support by adding bothtext/markdownand its deprecated variant withvalue/labelpairs. This aligns with the export-formats list pattern and ensures downstream components can handle Markdown consistently.components/google_drive/actions/download-file/download-file.mjs (1)
21-21: Increment action version to reflect bug fix
Updating from0.1.9to0.1.10properly signals the downstream change in export-format handling.components/google_drive/package.json (1)
3-3: Package version bump to 0.9.3
Bumping the component version aligns with the export-formats and Download File action updates.
|
/approve |
Resolves #17019
Summary by CodeRabbit
New Features
Chores