fix(publisher): fix redis command usage

[wuhuizuo]

This pull request introduces Redis integration into the publisher service, refactoring the code to accommodate the new Redis client and updating the handling of Redis commands. The most important changes include adding the Redis client configuration, modifying the Publisher and Service structs, and updating Redis command methods.

Redis Integration:

• publisher/cmd/worker/main.go: Added Redis client configuration and passed the Redis client to the tiup.NewPublisher function. [1] [2]

Struct Modifications:

• publisher/pkg/config/config.go: Added a Redis struct to hold Redis configuration and updated the Worker and Service structs to include this new Redis field.

Redis Command Updates:

• publisher/pkg/impl/tiup/publisher.go: Changed the redisClient type from *redis.Client to redis.Cmdable and updated Redis command methods to use SetXX instead of Set. [1] [2] [3]
• publisher/pkg/impl/tiup/service.go: Updated the redisClient type and changed the Redis command method from SetXX to SetNX for initial status setting. [1] [2]

Signed-off-by: wuhuizuo [email protected]

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request, the key changes involve the modification of the redisClient variable in two different files. The redisClient variable was changed from *redis.Client to redis.Cmdable. The redisClient.Set() function calls were also changed to redisClient.SetXX() and redisClient.SetNX() in different parts of the code.

There are no potential problems that can be identified in this pull request, and the changes seem to be well-implemented.

However, it is suggested to provide more context in the pull request description, such as the reason for the changes, the impact on the overall codebase, and any testing that has been done to ensure the changes are correct. This will help the reviewers understand the changes better and provide more meaningful feedback.

Additionally, it is recommended to follow consistent naming conventions across the codebase. For example, if the variable name is redisClient in one file, it should be named the same way in all other files where it is being used.

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

This pull request aims to fix the Redis command usage in the publisher application. Specifically, it adds a Redis struct to the config package, modifies the NewPublisher function and Publisher struct in the tiup package to accept a redisClient, and uses redisClient to replace redis.Client() in the Publisher.Handle function.

There are no potential problems with this pull request. However, it would be better to use SetNX instead of SetXX in the tiupsrvc.RequestToPublish function to avoid accidentally overwriting existing values.

Here is the suggested fix:

-		if err := s.redisClient.SetXX(ctx, requestID, PublishStateQueued, s.stateTTL).Err(); err != nil {
+		if err := s.redisClient.SetNX(ctx, requestID, PublishStateQueued, s.stateTTL).Err(); err != nil {

Overall, the changes look good and should be merged.

[wuhuizuo]

/approve

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [wuhuizuo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment