-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove mac test pipeline from storage repos #3324
base: main
Are you sure you want to change the base?
Conversation
Based on the pull request title and diff, it seems that the change removes the As for potential problems, it is not mentioned why the pipeline is being removed. If it is because it is no longer necessary, then there should be no issue. However, if it is removed because it is not working or causing issues, then this needs to be addressed. If the pipeline is no longer necessary, it would be a good idea to add a brief explanation in the pull request description to clarify the rationale behind the change. As for fixing suggestions, if the pipeline is being removed because it is not working or causing issues, it would be good to mention the steps taken to address the problem. Additionally, it would be helpful to provide any alternative solutions or pipelines that can be used to replace the removed pipeline. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Yang Zhang <[email protected]>
cf145f1
to
b5bd9da
Compare
Based on the PR title and diff, the changes made are to remove the mac test pipeline from Titan. The PR removes the There are no potential problems identified in this PR. However, it is always a good practice to ensure that the changes made do not impact the functionality of other parts of the pipeline. One suggestion to improve this PR is to add a brief description in the pull request description explaining the reason for removing the |
/cc @glorv @Connor1996 |
Will this change increase the likelihood of TiKV failing to build on macOS? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many of us are still developing on mac, we better not disable it. Why tests run slow on macos?
I think this is because the currently available Mac machine is the Mac Mini with an Intel i7 chip, which has relatively weak performance. |
How about using |
TiKV's RocksDB's fork's CI disabled
mac
build anyway. Andmac
build is too slow in Titan's and rust-rocksdb's CI. So, disablemac
build across storage repos' (RocksDB, Titan, rust-rocksdb) CI.