Mind Control Threshold #627

FS-21 · 2022-05-05T17:58:10Z

Now MC weapons can replace the Mind Control stuff by alternative warheads if the enemy health percentage is over the MindControl.threshold value.

More information in the documentation.

Now MC weapons can replace the Mind Control stuff by alternative warheads if the enemy health percentage is over the MindControl.threshold value.

github-actions · 2022-05-05T18:02:38Z

Nightly build for this pull request:

compiled-dll-b9b02876d5445b029f8082696031bf50b6aacc39.zip
This comment is automatic and is meant to allow guests to get latest nightly builds without registering. It is updated on every successful build.

Metadorius · 2022-05-05T18:12:58Z

Can't such functionality be implemented using Crit.AffectsBelowPercent already without any modifications to the code?

Starkku · 2022-05-05T19:35:01Z

Can't such functionality be implemented using Crit.AffectsBelowPercent already without any modifications to the code?

MindControl is special logic that doesn't quite work through the critical hit system. The crit warhead wouldn't count as mind control warhead and the unit wouldn't have the CaptureManagerClass set up or the MC pips if it is its only MC weapon either.

Also there's no need to reinvent the wheel with the odd percentage parsing and health calculations. INI parser happily parses percentages to double and ObjectClass::GetHealthPercentage() exists.

Use MapClass::SelectDamageAnimation() to pick the animation to display from the new warhead instead of reimplementing all the checks yourself. Current implementation doesn't even consider Conventional and excludes stuff like SplashList.

Having the threshold without having to set the Damage and Warhead could also be desirable.

Metadorius · 2022-05-05T19:47:16Z

Perhaps having an option to invert threshold would be good? I already see two usecases:

weaken enemy until mind controllable;
kill enemy if he's too weak to be controlled.

FS-21 · 2022-05-06T06:01:44Z

Also there's no need to reinvent the wheel with the odd percentage parsing and health calculations. INI parser happily parses percentages to double and ObjectClass::GetHealthPercentage() exists.

The only reason to reinvent the wheel was that in the first implementations that method returned unrealistic huge numbers so I made calculations by hand as you can see.
After reading this message and with the current checks the object returns valid values between 0.0 to 1.00000000... so I'll do the suggested changes.

Use MapClass::SelectDamageAnimation() to pick the animation to display from the new warhead instead of reimplementing all the checks yourself. Current implementation doesn't even consider Conventional and excludes stuff like SplashList.

Phobos develop branch doesn't use this method so the only 2 valid examples are located in Ares sources... I'll try later (because ask for values I never used like land Type etc) but the current animation code is C&P from Crit system so if is incomplete here the same there.

Having the threshold without having to set the Damage and Warhead could also be desirable.

I don't understand this, can you explain it, please?

FS-21 · 2022-05-06T06:06:13Z

Perhaps having an option to invert threshold would be good? I already see two usecases:

weaken enemy until mind controllable;

kill enemy if he's too weak to be controlled.

Yes, the 2 user cases you mentioned are covered with the current tags. I had in mind the multi-engineer logic from RA1.

I don't know if that is useful. Inverting the threshold means:

Mind control units until the unit HP % is lower than the threshold, then the unit can be hurt to death.

Maybe a 'healer' that can MC units if the HP % is over the threshold?

due to feedback.

FS-21 · 2022-05-06T15:55:22Z

Applied feedback with those 2 internal changes.
Looks that anims from the alternative WH works with water etc.

I forgot to replace 1 line of code

Due a change in YRpp

MindControl.Threshold.Inverse=bool Instead of damage if enemy HP percentage is over the threshold if the tag is "true" the comparison is flipped (over the threshold Mind-Control and below the threshold damage the mind-controllable target). MindControl.Damage now is called MindControl.AlternativeDamage MindControl.Warhead now is called MindControl.AlternativeWarhead

…l-Threshold

MaxLenarc · 2022-05-16T21:46:16Z

Max Lenarc here, just reporting my attempt to test the Mind Control Threshold from a while ago since I have not posted here in Github. I doubt it will be useful though. Ultimately failed to get the feature to work, not sure why though. I have the latest nightly build with the code given to me on Mod Haven. I think it may be a case of the code being put in the wrong spot in the INI?
INI looks like this.
"[Controller]
Verses=100%,100%,100%,100%,100%,100%,0%,0%,0%,0%,100%
MindControl=yes
AnimList=YURICNTL
AffectsAllies=no

Versus.mcvheavy=0%
Versus.mcvheavy.Retaliate=no
Versus.mcvheavy.ForceFire=no
Versus.mcvheavy.PassiveAcquire=no

Versus.t2mediump=0%
Versus.t2mediump.Retaliate=no
Versus.t2mediump.ForceFire=no
Versus.t2mediump.PassiveAcquire=no

Versus.t2heavyp=0%
Versus.t2heavyp.Retaliate=no
Versus.t2heavyp.ForceFire=no
Versus.t2heavyp.PassiveAcquire=no

Versus.t3heavyp=0%
Versus.t3heavyp.Retaliate=no
Versus.t3heavyp.ForceFire=no
Versus.t3heavyp.PassiveAcquire=no

Versus.mindarm=0%
Versus.mindarm.Retaliate=no
Versus.mindarm.ForceFire=no
Versus.mindarm.PassiveAcquire=no
Versus.sbanearmor=0%

Transact=true
DamageAirThreshold=-1 ; boolean
Transact.SpreadAmongTargets=false ; boolean
Transact.Experience.Source.Flat=0 ; integer
Transact.Experience.Source.Percent=0.40 ; float, percents or absolute (-1.0 - 1.0)
Transact.Experience.Source.Percent.CalcFromTarget=true ; boolean
Transact.Experience.Target.Flat=0 ; integer
Transact.Experience.Target.Percent=0.0 ; float, percents or absolute (-1.0 - 1.0)
Transact.Experience.Target.Percent.CalcFromSource=false ; boolean

MindControl.Threshold= 25% ; positive percentage. Represents a percentage from 0% to 100%
MindControl.AlternativeDamage= 50 ; integer
MindControl.AlternativeWarhead= PsychoFire; warhead
MindControl.CanKill= false ; boolean
MindControl.Threshold.Inverse= false ; boolean

[PsychoFire]
Wall=no
Wood=no
Sparky=yes
Verses=100%,100%,100%,100%,100%,100%,50%,50%,50%,100%,100%
Conventional=yes
InfDeath=10
AnimList=UCINIT
ProneDamage=75%"
Both of these are under the Warheads list. Apologies in advance if this ends of being a waste of time, also for the wall of text. Tested this on Rise of the East.

brsajo · 2022-06-08T11:38:28Z

Ultimately failed to get the feature to work, not sure why though. I have the latest nightly build with the code given to me on Mod Haven. I think it may be a case of the code being put in the wrong spot in the INI?

There are some errors in the documentation. It says "AlternativeDamage/Warhead" but the actual tags are "AlternateDamage/Warhead".
It also says "the health’s victim" when it should say "the victim's health" or to be consistent with the ini tags, "the victim's strength".

Updated the tag names in the documentation

FS-21 · 2022-07-04T18:49:37Z

Ultimately failed to get the feature to work, not sure why though. I have the latest nightly build with the code given to me on Mod Haven. I think it may be a case of the code being put in the wrong spot in the INI?

There are some errors in the documentation. It says "AlternativeDamage/Warhead" but the actual tags are "AlternateDamage/Warhead". It also says "the health’s victim" when it should say "the victim's health" or to be consistent with the ini tags, "the victim's strength".

I updated the tag names in the docs with your feedback.

FS-21 · 2022-07-04T18:50:08Z

Max Lenarc here, just reporting my attempt to test the Mind Control Threshold from a while ago since I have not posted here in Github. I doubt it will be useful though. Ultimately failed to get the feature to work, not sure why though. I have the latest nightly build with the code given to me on Mod Haven. I think it may be a case of the code being put in the wrong spot in the INI? INI looks like this. "[Controller] Verses=100%,100%,100%,100%,100%,100%,0%,0%,0%,0%,100% MindControl=yes AnimList=YURICNTL AffectsAllies=no

Versus.mcvheavy=0% Versus.mcvheavy.Retaliate=no Versus.mcvheavy.ForceFire=no Versus.mcvheavy.PassiveAcquire=no

Versus.t2mediump=0% Versus.t2mediump.Retaliate=no Versus.t2mediump.ForceFire=no Versus.t2mediump.PassiveAcquire=no

Versus.t2heavyp=0% Versus.t2heavyp.Retaliate=no Versus.t2heavyp.ForceFire=no Versus.t2heavyp.PassiveAcquire=no

Versus.t3heavyp=0% Versus.t3heavyp.Retaliate=no Versus.t3heavyp.ForceFire=no Versus.t3heavyp.PassiveAcquire=no

Versus.mindarm=0% Versus.mindarm.Retaliate=no Versus.mindarm.ForceFire=no Versus.mindarm.PassiveAcquire=no Versus.sbanearmor=0%

Transact=true DamageAirThreshold=-1 ; boolean Transact.SpreadAmongTargets=false ; boolean Transact.Experience.Source.Flat=0 ; integer Transact.Experience.Source.Percent=0.40 ; float, percents or absolute (-1.0 - 1.0) Transact.Experience.Source.Percent.CalcFromTarget=true ; boolean Transact.Experience.Target.Flat=0 ; integer Transact.Experience.Target.Percent=0.0 ; float, percents or absolute (-1.0 - 1.0) Transact.Experience.Target.Percent.CalcFromSource=false ; boolean

MindControl.Threshold= 25% ; positive percentage. Represents a percentage from 0% to 100% MindControl.AlternativeDamage= 50 ; integer MindControl.AlternativeWarhead= PsychoFire; warhead MindControl.CanKill= false ; boolean MindControl.Threshold.Inverse= false ; boolean

[PsychoFire] Wall=no Wood=no Sparky=yes Verses=100%,100%,100%,100%,100%,100%,50%,50%,50%,100%,100% Conventional=yes InfDeath=10 AnimList=UCINIT ProneDamage=75%" Both of these are under the Warheads list. Apologies in advance if this ends of being a waste of time, also for the wall of text. Tested this on Rise of the East.

The problem was the tag names, I updated the docs.

MaxLenarc · 2022-07-04T22:20:44Z

So that was the problem. Thanks for the info!

FS-21 · 2022-07-05T08:24:06Z

So that was the problem. Thanks for the info!

Try it so we can label it as tested

MaxLenarc · 2022-07-05T22:13:23Z

Got to testing it again. Everyone works as intended. Admittedly I misunderstood what MindControl.Threshold.Inverse did at first; I thought it killed Mind Controlled units under the Threshold, not kill unit enemy units under the Threshold. I think it is good to go. One of the coolest logics I've seen here!

github-actions · 2023-07-22T15:34:31Z

Nightly build for this pull request:

compiled-dll-ecbbd882aa32eba2e5fe107efed26e0da3838a62.zip
These artifacts will expire in 90 days and will not be available for download after that time.

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

coderabbitai · 2024-03-14T15:01:12Z

Warning

Rate Limit Exceeded

@FS-21 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 28 minutes and 45 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between eef9bc0 and b97dde5.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Starkku

The entire implementation could be generalized and massively simplified. There is nothing about this feature that would inherently require tying it to MindControl. In addition the current implementation reimplements a lot of things that it really does not need to.

In fact, because we now have ExtraWarheads this feature can be simplified down a lot. You can generalize the threshold system to not be tied to MindControl, remove all of the unnecessary (nullptr) checks that just bloat and slow down the code - only thing you realistically need to check is that the bullet's target is instance of ObjectClass or derived classes, e.g it has health. There's no need for damage, there's no need to Warheads or kill switches. The only thing needed is skipping Warhead detonation if the threshold check passees. Because we have ExtraWarheads, you can combine two or more Warheads to create health-based conditional Warhead detonation this way without requiring any other bespoke code.

Only issue is that swapping from regular -> MindControl via ExtraWarheads won't work due to absence of CaptureManagerClass but that could hypothetically be fixed. And it is not like this feature's original scope implemented that scenario either.

Metadorius

EDIT: missed that Starkku has already posted the essay, I basically posted more or less the same but with more details and suggestions/explanations. Hopefully would still be useful.

I think the way this feature is designed is too specific. IMO the best would be reworking it into generic threshold logic.

After some brainstorming with @Starkku we came to conclusion that this whole logic can be made much simpler and much more usable. Per idea you would only implement two tags:

[SOMEWARHEAD]
AffectsBelowPercent=100%  ; means HP of the target
AffectsAbovePercent=0%    ; means HP of the target

(both conditions must be fulfilled for the warhead to activate so it works like a range, for example you could have a range between 20% and 80% percents. The code would be just a two-line check at the very beginning of BulletClass::Logics that would bail from func if the conditions pass)

Why? Because we should be doing features that mesh with other features like bricks in the wall, and not overly specific and hardly reusable ones. This way every small feature is simple, and together the features allow for great flexibility.

As such, if you combine it with Crit or ExtraWarhead logics you can do an arbitrary amount of warheads activating at arbitrary HP ranges. CanKill can be done with relative damage logic, or if needed it could be implemented as a separate feature.

As for the mind control itself it only works if CaptureManagerClass is inited for the firer, which currently only happens if one of the weapons is MC one, so to fix that you could iterate all the weapons with their normal, extra and crit (and other possible) warheads that the unit has on init (how the game does it, won't work in edge cases like interceptor replcaing WH with a MC WH), or check for CaptureManagerClass when the MC occurs, and if not inited and the firer is there - init it. Or both, which would probably be the best.

Metadorius · 2024-07-07T11:36:53Z

docs/New-or-Enhanced-Logics.md

+```ini
+MindControl.Threshold=100% or 1.0   ; positive percentage. Represents a percentage from 0% to 100%


Missing section

FS-21 · 2024-07-12T09:21:41Z

Due to the well explained feedback is much better if I close this PR and I rewrite the feature from 0 following the suggestions. When I arrive home I'll close this.

Metadorius · 2024-07-13T19:33:27Z

Well you can simply reuse this PR and just re-code, this shouldn't take much time or changes.

FS-21 · 2024-08-29T11:32:19Z

Because I need it for releasing my next mod release I'll update with latest develop commit and then mark it as "draft" because I need to rewrite all the code.

…l-Threshold

Metadorius · 2024-09-27T21:22:48Z

I'll close this PR for the time being, let's move onto the #1398.

Initial commit

f2328c2

Now MC weapons can replace the Mind Control stuff by alternative warheads if the enemy health percentage is over the MindControl.threshold value.

Applied requested internal changes

43457ee

due to feedback.

FS-21 added 6 commits May 6, 2022 17:56

Small change

47d9310

I forgot to replace 1 line of code

small tweak

9749a5a

Fix spelling error

d2afca6

Merge branch 'develop' into feature/MindControl-Threshold

6012fa0

Point to latest YRpp

76576c2

Fix compilation

90236ce

Due a change in YRpp

FS-21 added the Needs testing label May 10, 2022

Metadorius force-pushed the develop branch 2 times, most recently from 0fa5476 to da80463 Compare May 11, 2022 17:01

FS-21 added 3 commits May 12, 2022 19:55

Updated documentation

d3078f1

Merge remote-tracking branch 'origin/develop' into feature/MindContro…

6862496

…l-Threshold

FS-21 added 2 commits July 4, 2022 20:37

Merge branch 'develop' into feature/MindControl-Threshold

83d3d31

Updated docs

756d826

Updated the tag names in the documentation

Starkku force-pushed the develop branch from aae92fd to a32076e Compare June 3, 2023 10:14

FS-21 added 2 commits July 22, 2023 17:19

Merge branch 'develop' into feature/MindControl-Threshold

d1b9eba

YRpp update

472b9e6

FS-21 added 5 commits September 23, 2023 11:24

Merge branch 'develop' into feature/MindControl-Threshold

162fa35

Merge branch 'develop' into feature/MindControl-Threshold

8294a6f

Merge branch 'develop' into feature/MindControl-Threshold

9d0bd9a

Fix compilation

9003cbf

Merge branch 'develop' into feature/MindControl-Threshold

b97dde5

FS-21 added 2 commits April 30, 2024 14:44

Merge branch 'develop' into feature/MindControl-Threshold

0c7dba6

Fixed a rare crash

cb2d3f5

chaserli force-pushed the develop branch from 7a22efe to c801eb9 Compare June 9, 2024 14:18

Starkku requested changes Jul 7, 2024

View reviewed changes

Metadorius requested changes Jul 7, 2024

View reviewed changes

Metadorius added Needs Update This branch needs to be updated with upstream for testing and reviews Needs Rework The structure or methodology is "mise en question" and removed Needs improvement Needs testing labels Jul 7, 2024

Metadorius self-assigned this Jul 7, 2024

FS-21 marked this pull request as draft August 29, 2024 11:32

FS-21 added 2 commits August 29, 2024 13:37

Merge remote-tracking branch 'origin/develop' into feature/MindContro…

1696b62

…l-Threshold

Merge branch 'develop' into feature/MindControl-Threshold

359f85f

Metadorius removed the Needs Update This branch needs to be updated with upstream for testing and reviews label Sep 26, 2024

Metadorius mentioned this pull request Sep 27, 2024

Warhead activation target health thresholds #1398

Open

Metadorius closed this Sep 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mind Control Threshold #627

Mind Control Threshold #627

FS-21 commented May 5, 2022

github-actions bot commented May 5, 2022 •

edited

Loading

Metadorius commented May 5, 2022 •

edited

Loading

Starkku commented May 5, 2022 •

edited

Loading

Metadorius commented May 5, 2022

FS-21 commented May 6, 2022

FS-21 commented May 6, 2022 •

edited

Loading

FS-21 commented May 6, 2022 •

edited

Loading

MaxLenarc commented May 16, 2022 •

edited

Loading

brsajo commented Jun 8, 2022

FS-21 commented Jul 4, 2022

FS-21 commented Jul 4, 2022

MaxLenarc commented Jul 4, 2022

FS-21 commented Jul 5, 2022 •

edited

Loading

MaxLenarc commented Jul 5, 2022

github-actions bot commented Jul 22, 2023 •

edited

Loading

coderabbitai bot commented Mar 14, 2024

Rate Limit Exceeded

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

CodeRabbit Discord Community

Starkku left a comment •

edited

Loading

Metadorius left a comment •

edited

Loading

Metadorius Jul 7, 2024

FS-21 commented Jul 12, 2024 •

edited

Loading

Metadorius commented Jul 13, 2024

FS-21 commented Aug 29, 2024

Metadorius commented Sep 27, 2024

		```ini
		MindControl.Threshold=100% or 1.0 ; positive percentage. Represents a percentage from 0% to 100%

Mind Control Threshold #627

Mind Control Threshold #627

Conversation

FS-21 commented May 5, 2022

github-actions bot commented May 5, 2022 • edited Loading

Metadorius commented May 5, 2022 • edited Loading

Starkku commented May 5, 2022 • edited Loading

Metadorius commented May 5, 2022

FS-21 commented May 6, 2022

FS-21 commented May 6, 2022 • edited Loading

FS-21 commented May 6, 2022 • edited Loading

MaxLenarc commented May 16, 2022 • edited Loading

brsajo commented Jun 8, 2022

FS-21 commented Jul 4, 2022

FS-21 commented Jul 4, 2022

MaxLenarc commented Jul 4, 2022

FS-21 commented Jul 5, 2022 • edited Loading

MaxLenarc commented Jul 5, 2022

github-actions bot commented Jul 22, 2023 • edited Loading

coderabbitai bot commented Mar 14, 2024

Rate Limit Exceeded

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

CodeRabbit Discord Community

Starkku left a comment • edited Loading

Choose a reason for hiding this comment

Metadorius left a comment • edited Loading

Choose a reason for hiding this comment

Metadorius Jul 7, 2024

Choose a reason for hiding this comment

FS-21 commented Jul 12, 2024 • edited Loading

Metadorius commented Jul 13, 2024

FS-21 commented Aug 29, 2024

Metadorius commented Sep 27, 2024

github-actions bot commented May 5, 2022 •

edited

Loading

Metadorius commented May 5, 2022 •

edited

Loading

Starkku commented May 5, 2022 •

edited

Loading

FS-21 commented May 6, 2022 •

edited

Loading

FS-21 commented May 6, 2022 •

edited

Loading

MaxLenarc commented May 16, 2022 •

edited

Loading

FS-21 commented Jul 5, 2022 •

edited

Loading

github-actions bot commented Jul 22, 2023 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)

Starkku left a comment •

edited

Loading

Metadorius left a comment •

edited

Loading

FS-21 commented Jul 12, 2024 •

edited

Loading