Customizable Bars of Health Points #1395

Fryone · 2024-09-25T17:02:42Z

Added customizable health bars in form of BarTypes. By default, technos use their own vanilla healthbars.
Adding HealthBar.BarType changing health bar to this type. Can be applied to buildings.

Example

[BarTypes]                           ; section in rulesmd.ini
0=HEALTHBAR1

[HEALTHBAR1]
BoardBG.File=                        ; filename - without the .shp extension, image for use as background, first frame
BoardBG.ShowWhenNotSelected=false    ; boolean, should background be drawn, when ponting on techno
BoardBG.Translucency=                ; translucency level (0/25/50/75), background image translucency level
BoardFG.File=                        ; filename - without the .shp extension, image for use as foreground (drawn after health sections), first frame
BoardFG.ShowWhenNotSelected=false    ; boolean, should foreground be drawn, when ponting on techno
BoardFG.Translucency=                ; translucency level (0/25/50/75), foreground image translucency level
Board.Offset=0,0                     ; X,Y, offset of background and foreground boards images
Bar.Offset=0,0                       ; X,Y, offset of whole bar
Sections.DrawBackwards=false         ; boolean, changes order of drawing from last to first
Sections.EmptyPip=-1                 ; integer, frame in pips.shp to use for empty section
Sections.Pips=16,17,18               ; list of 3 integers, frames of pips.shp to use (green, yellow, red states)
Sections.Amount=17                   ; integer, amount of sections, when bar is full
Sections.PositionDelta=2,0           ; X,Y, increment in pixels to next section

[SOMETECHNO]
HealthBar.BarType=HEALTHBAR1

No docs for now, needs testing.

Initial commit

github-actions · 2024-09-25T17:07:49Z

Nightly build for this pull request:

compiled-dll-5d24a32d092a88abbdad6c3a0043859547d43034.zip
These artifacts will expire in 90 days and will not be available for download after that time.

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

tyuah8 · 2024-09-26T03:38:46Z

Added customizable vertical health bars in form of HealthBarTypes. By default, technos use their own vanilla healthbars. Adding CustomHealthBarType changing health bar to this type. Can be applied to buildings.

Example

[HealthBarTypes]                                                       ; section in rulesmd.ini
0=HEALTHBAR1

[HEALTHBAR1]
Frame.Background=PIPBRD                                      ; shp file for use as background, first frame
Frame.Background.Translucency=0                           ; background translucency level
Frame.Background.ShowWhenNotSelected=false    ; should background be drawn, when ponting on techno
Frame.Foreground=                                                   ; shp file for use as foreground (drawn after health sections), first frame
Frame.Foreground.ShowWhenNotSelected=false     ; should foreground be drawn, when ponting on techno
HealthBar.OffsetX=0                                                  ; horizontal offset, similar to PixelSelectionBracketDelta
Sections.Pips=16,17,18                                              ; frames of pips.shp to use (green, yellow, red states)
Sections.Amount=17                                                 ; amount of sections, when bar is full
Sections.Size=2                                                          ; size in px of individual section

[SOMETECHNO]
CustomHealthBarType=HEALTHBAR1

No docs for now, needs testing.

Those voxels are quite nice and seem to resemble the look and feel of the original game voxels. Did you make those voxels yourself?

Fryone · 2024-09-26T03:43:08Z

Those voxels are quite nice and seem to resemble the look and feel of the original game voxels. Did you make those voxels yourself?

yep

NetsuNegi · 2024-09-26T12:02:29Z

nice feature for epic vehicle/airship/battleship :)

Metadorius · 2024-09-26T17:27:35Z

Custom Health Bar

Metadorius · 2024-09-26T17:32:11Z

Couple of suggestions on the general API stuff:
[HealthBarTypes] => [BarTypes]
In general I propose to treat this as a "custom anything bar" which can be used for HP bars.

For technos the tag should be CustomHealthBarType => HealthBar, less redundancy and more in-line with other things.

I think shields should use that too.

Metadorius · 2024-09-26T17:33:55Z

P.S. Can you do any shape/direction bars this way? I think it's a matter of making the section offset customizable in two dimensions, this way you could specify the 2,2 offset and have the bar go diagonal for example.

Fryone · 2024-09-26T18:00:07Z

P.S. Can you do any shape/direction bars this way? I think it's a matter of making the section offset customizable in two dimensions, this way you could specify the 2,2 offset and have the bar go diagonal for example.

The horizontal (vanilla like) bars were first in mind. I understand vertical ones, but diagonal...

Metadorius · 2024-09-26T18:03:29Z

The horizontal (vanilla like) bars were first in mind. I understand vertical ones, but diagonal...

It's only an example. The point is that if one can specify offset between sections in 2 dimensions then they can come up with whatever weird graphics they want, including diagonal bars, sectioned graphics etc.

Fryone · 2024-09-26T18:06:42Z

I think, I probably should make some "BarMaker" then, like procedure to draw by position and type.

chaserli · 2024-09-27T15:37:12Z

#1287 #1309 #1395
#1287 (comment)
If you are making a bar, generalize it to cover all fractionable quantities. HP/SP are just a small part of them. Some should display regardless of mouse hovering/selected.

Fryone · 2024-09-27T15:41:57Z

#1287 #1309 #1395 #1287 (comment) If you are making a bar, generalize it to cover all fractionable quantities. HP/SP are just a small part of them. Some should display regardless of mouse hovering/selected.

yeah, so the bars can be used to draw without hovering/selecting. i'm just using bar-drawer in the vanilla health part code. So it behaves like vanilla health bar.

chaserli · 2024-09-27T15:46:05Z

yeah, so the bars can be used to draw without hovering/selecting. i'm just using bar-drawer in the vanilla health part code. So it behaves like vanilla health bar.

I mean you can go more aggressive than that, just replace all 4 DrawHealthBar vtbl calls and handle it as well as other things in drawextras.

- added emptypip - added draw direction - added border offset - changed overall logic

ZivDero · 2024-09-28T19:55:00Z

src/Ext/Techno/Body.Visuals.cpp

+		DSurface::Temp->DrawSHP(FileSystem::PALETTE_PAL, barType->BoardBG_File.Get(),
+				0, &boardPosition, pBounds, BlitterFlags(0xE00) | blitFlagsBG, 0, 0, ZGradient::Ground, 1000, 0, 0, 0, 0, 0);
+


Please elaborate blitterflags:
BlitterFlags::MultiPass | BlitterFlags::Centered | BlitterFlags::bf_400

ZivDero · 2024-09-28T19:56:05Z

src/Ext/Techno/Body.Visuals.cpp

+		{
+			position += drawBackwards ? -sectionOffset : sectionOffset;
+			DSurface::Temp->DrawSHP(FileSystem::PALETTE_PAL, FileSystem::PIPS_SHP(),
+					sectionEmptyFrame, &position, pBounds, BlitterFlags(0x600), 0, 0, ZGradient::Ground, 1000, 0, 0, 0, 0, 0);


Same as above for the flags.

ZivDero · 2024-09-28T19:56:08Z

src/Ext/Techno/Body.Visuals.cpp

+	{
+		position += drawBackwards ? -sectionOffset : sectionOffset;
+		DSurface::Temp->DrawSHP(FileSystem::PALETTE_PAL, FileSystem::PIPS_SHP(),
+				frameIdxa, &position, pBounds, BlitterFlags(0x600), 0, 0, ZGradient::Ground, 1000, 0, 0, 0, 0, 0);


Same as above for the flags.

ZivDero · 2024-09-28T19:56:11Z

src/Ext/Techno/Body.Visuals.cpp

+
+	if(barType->BoardFG_File && (pThis->IsSelected || barType->BoardFG_ShowWhenNotSelected))
+		DSurface::Temp->DrawSHP(FileSystem::PALETTE_PAL, barType->BoardFG_File.Get(),
+				0, &boardPosition, pBounds, BlitterFlags(0xE00) | blitFlagsFG, 0, 0, ZGradient::Ground, 1000, 0, 0, 0, 0, 0);


Same as above for the flags.

ZivDero · 2024-09-28T20:00:24Z

src/New/Type/BarTypeClass.h

+	Nullable<SHPStruct*> BoardBG_File;
+	Valueable<bool> BoardBG_ShowWhenNotSelected;
+	Nullable<TranslucencyLevel> BoardBG_Translucency;
+	Nullable<SHPStruct*> BoardFG_File;
+	Valueable<bool> BoardFG_ShowWhenNotSelected;
+	Nullable<TranslucencyLevel> BoardFG_Translucency;
+	Valueable<Vector2D<int>> Board_Offset;


Board -> Frame?

also BG/FG -> Background/Foreground, please

Metadorius · 2024-09-28T17:38:54Z

src/Ext/Techno/Body.Visuals.cpp

+	if(sectionEmptyFrame != -1)
+	{
+		for(int i = 0; i < sectionAmount; ++i)


Suggested change

if(sectionEmptyFrame != -1)

{

for(int i = 0; i < sectionAmount; ++i)

if (sectionEmptyFrame != -1)

{

for (int i = 0; i < sectionAmount; ++i)

Metadorius · 2024-09-28T17:39:31Z

src/Ext/Techno/Body.Visuals.cpp

+	if(drawBackwards)
+		for(int i = 0; i < (sectionAmount - sectionsToDraw); ++i)
+			position -= sectionOffset;


Suggested change

if(drawBackwards)

for(int i = 0; i < (sectionAmount - sectionsToDraw); ++i)

position -= sectionOffset;

if (drawBackwards)

{

for (int i = 0; i < (sectionAmount - sectionsToDraw); ++i)

position -= sectionOffset;

}

Metadorius · 2024-09-28T17:39:42Z

src/Ext/Techno/Body.Visuals.cpp

+		for(int i = 0; i < (sectionAmount - sectionsToDraw); ++i)
+			position -= sectionOffset;
+
+	for(int i = 0; i < sectionsToDraw; ++i)


Suggested change

for(int i = 0; i < sectionsToDraw; ++i)

for (int i = 0; i < sectionsToDraw; ++i)

Metadorius · 2024-09-28T17:49:17Z

src/New/Type/BarTypeClass.h

+		, Board_Offset { { 0,0 } }
+		, Bar_Offset { { 0,0 } }
+		, Sections_DrawBackwards { false }
+		, Sections_Pips { { 16,17,18 } }
+		, Sections_EmptyPip { -1 }
+		, Sections_Amount { 17 }
+		, Sections_PositionDelta { { 2,0 } }


Suggested change

, Board_Offset { { 0,0 } }

, Bar_Offset { { 0,0 } }

, Sections_DrawBackwards { false }

, Sections_Pips { { 16,17,18 } }

, Sections_EmptyPip { -1 }

, Sections_Amount { 17 }

, Sections_PositionDelta { { 2,0 } }

, Board_Offset { { 0, 0 } }

, Bar_Offset { { 0, 0 } }

, Sections_DrawBackwards { false }

, Sections_Pips { { 16, 17, 18 } }

, Sections_EmptyPip { -1 }

, Sections_Amount { 17 }

, Sections_PositionDelta { { 2, 0 } }

Metadorius · 2024-09-28T17:52:02Z

src/Ext/Techno/Hooks.Pips.cpp

+	if(!pTypeExt->HealthBar_BarType)
+	{
+		R->AL(pThis->IsSelected);
+		if(pThisIsInf)


Suggested change

if(pThisIsInf)

if (pThisIsInf)

Metadorius · 2024-09-28T19:50:03Z

src/Ext/Techno/Body.Visuals.cpp

+				frameIdxa, &position, pBounds, BlitterFlags(0x600), 0, 0, ZGradient::Ground, 1000, 0, 0, 0, 0, 0);
+	}
+
+	if(barType->BoardFG_File && (pThis->IsSelected || barType->BoardFG_ShowWhenNotSelected))


Suggested change

if(barType->BoardFG_File && (pThis->IsSelected || barType->BoardFG_ShowWhenNotSelected))

if (barType->BoardFG_File && (pThis->IsSelected || barType->BoardFG_ShowWhenNotSelected))

Metadorius · 2024-09-28T19:51:09Z

src/Ext/Techno/Body.h

@@ -168,6 +168,7 @@ class TechnoExt
 	static Point2D GetBuildingSelectBracketPosition(TechnoClass* pThis, BuildingSelectBracketPosition bracketPosition);
 	static void ProcessDigitalDisplays(TechnoClass* pThis);
 	static void GetValuesForDisplay(TechnoClass* pThis, DisplayInfoType infoType, int& value, int& maxValue);
+	static void DrawBar(TechnoClass* pThis, BarTypeClass* barType, Point2D pLocation, RectangleStruct* pBounds, double barPercentage, double yellowCond, double redCond);


conditionYellow and conditionRed maybe?

Metadorius · 2024-09-28T20:06:20Z

src/Ext/Techno/Body.Visuals.cpp

+		position.X += drawBackwards ? (int)round(sectionAmount * sectionOffset.X / 2) : -(int)round(sectionAmount * sectionOffset.X / 2);
+		position.Y += drawBackwards ? (int)round(sectionAmount * sectionOffset.Y / 2) : -(int)round(sectionAmount * sectionOffset.Y / 2);


Pretty sure you can do math with vectors like normal, you don't need to duplicate it for each coord.

Instead of a ternary operator and duplication everywhere where you need to decide on the direction of draw you can do int sign = drawBackwards * -2 + 1; and multiply by that every time you used a ternary here.

This all applies to multiple lines in the code btw, forgot to comment on all of them, please see where it is applicable because there's a lot of duplication going on.

Metadorius · 2024-09-28T20:07:56Z

src/Ext/Techno/Body.Visuals.cpp

+		for(int i = 0; i < sectionAmount; ++i)
+		{
+			position += drawBackwards ? -sectionOffset : sectionOffset;
+			DSurface::Temp->DrawSHP(FileSystem::PALETTE_PAL, FileSystem::PIPS_SHP(),


Could make pips.shp customizable too?

Metadorius · 2024-09-28T20:09:58Z

src/New/Type/BarTypeClass.h

+	Nullable<TranslucencyLevel> BoardBG_Translucency;
+	Nullable<SHPStruct*> BoardFG_File;
+	Valueable<bool> BoardFG_ShowWhenNotSelected;
+	Nullable<TranslucencyLevel> BoardFG_Translucency;
+	Valueable<Vector2D<int>> Board_Offset;


Not sure why translucency flags are nullable here when they can just be valueables with default 0?

ZivDero · 2024-09-28T20:21:00Z

Also, you're hooking into the function. But the vanilla function is just one big if-else, and you hook both of the branches. You should replace the entire function.

Additionally, your hooks disable other Phobos hooks (shield bars, HeathBar.Height, digital displays). As such, you should move those patches into your replaced function, too.

custom health bar types

514420d

Initial commit

Fryone changed the title ~~Custom Health Bars~~ Customizable Bars of Health Points Sep 26, 2024

changed to BarTypes

35350e4

- added emptypip - added draw direction - added border offset - changed overall logic

ZivDero requested changes Sep 28, 2024

View reviewed changes

Metadorius requested changes Sep 28, 2024

View reviewed changes

Metadorius assigned ZivDero and Metadorius Sep 28, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Customizable Bars of Health Points #1395

Customizable Bars of Health Points #1395

Fryone commented Sep 25, 2024 •

edited by Belonit

Loading

github-actions bot commented Sep 25, 2024 •

edited

Loading

tyuah8 commented Sep 26, 2024

Fryone commented Sep 26, 2024

NetsuNegi commented Sep 26, 2024

Metadorius commented Sep 26, 2024

Metadorius commented Sep 26, 2024

Metadorius commented Sep 26, 2024

Fryone commented Sep 26, 2024

Metadorius commented Sep 26, 2024

Fryone commented Sep 26, 2024

chaserli commented Sep 27, 2024

Fryone commented Sep 27, 2024

chaserli commented Sep 27, 2024

ZivDero Sep 28, 2024

ZivDero Sep 28, 2024

ZivDero Sep 28, 2024

ZivDero Sep 28, 2024

ZivDero Sep 28, 2024

Metadorius Sep 28, 2024

Metadorius Sep 28, 2024

Metadorius Sep 28, 2024

Metadorius Sep 28, 2024

Metadorius Sep 28, 2024

Metadorius Sep 28, 2024

Metadorius Sep 28, 2024

Metadorius Sep 28, 2024

Metadorius Sep 28, 2024

Metadorius Sep 28, 2024

Metadorius Sep 28, 2024

ZivDero commented Sep 28, 2024

		DSurface::Temp->DrawSHP(FileSystem::PALETTE_PAL, barType->BoardBG_File.Get(),
		0, &boardPosition, pBounds, BlitterFlags(0xE00) \| blitFlagsBG, 0, 0, ZGradient::Ground, 1000, 0, 0, 0, 0, 0);

	for(int i = 0; i < sectionsToDraw; ++i)
	for (int i = 0; i < sectionsToDraw; ++i)

	if(barType->BoardFG_File && (pThis->IsSelected \|\| barType->BoardFG_ShowWhenNotSelected))
	if (barType->BoardFG_File && (pThis->IsSelected \|\| barType->BoardFG_ShowWhenNotSelected))

		position.X += drawBackwards ? (int)round(sectionAmount * sectionOffset.X / 2) : -(int)round(sectionAmount * sectionOffset.X / 2);
		position.Y += drawBackwards ? (int)round(sectionAmount * sectionOffset.Y / 2) : -(int)round(sectionAmount * sectionOffset.Y / 2);

Customizable Bars of Health Points #1395

Are you sure you want to change the base?

Customizable Bars of Health Points #1395

Conversation

Fryone commented Sep 25, 2024 • edited by Belonit Loading

github-actions bot commented Sep 25, 2024 • edited Loading

tyuah8 commented Sep 26, 2024

Fryone commented Sep 26, 2024

NetsuNegi commented Sep 26, 2024

Metadorius commented Sep 26, 2024

Metadorius commented Sep 26, 2024

Metadorius commented Sep 26, 2024

Fryone commented Sep 26, 2024

Metadorius commented Sep 26, 2024

Fryone commented Sep 26, 2024

chaserli commented Sep 27, 2024

Fryone commented Sep 27, 2024

chaserli commented Sep 27, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ZivDero commented Sep 28, 2024

Fryone commented Sep 25, 2024 •

edited by Belonit

Loading

github-actions bot commented Sep 25, 2024 •

edited

Loading