Customizable Bars of Health Points #1395

Fryone · 2024-09-25T17:02:42Z

Added customizable health bars in form of BarTypes. By default, technos use their own vanilla healthbars.
Adding HealthBar.BarType changing health bar to this type. Can be applied to buildings.

Example

[BarTypes]                           ; section in rulesmd.ini
0=HEALTHBAR1

[HEALTHBAR1]
BoardBG.File=                        ; filename - without the .shp extension, image for use as background, first frame
BoardBG.ShowWhenNotSelected=false    ; boolean, should background be drawn, when ponting on techno
BoardBG.Translucency=                ; translucency level (0/25/50/75), background image translucency level
BoardFG.File=                        ; filename - without the .shp extension, image for use as foreground (drawn after health sections), first frame
BoardFG.ShowWhenNotSelected=false    ; boolean, should foreground be drawn, when ponting on techno
BoardFG.Translucency=                ; translucency level (0/25/50/75), foreground image translucency level
Board.Offset=0,0                     ; X,Y, offset of background and foreground boards images
Bar.Offset=0,0                       ; X,Y, offset of whole bar
Sections.DrawBackwards=false         ; boolean, changes order of drawing from last to first
Sections.EmptyPip=-1                 ; integer, frame in pips.shp to use for empty section
Sections.Pips=16,17,18               ; list of 3 integers, frames of pips.shp to use (green, yellow, red states)
Sections.Amount=17                   ; integer, amount of sections, when bar is full
Sections.PositionDelta=2,0           ; X,Y, increment in pixels to next section

[SOMETECHNO]
HealthBar.BarType=HEALTHBAR1

No docs for now, needs testing.

Initial commit

github-actions · 2024-09-25T17:07:49Z

Nightly build for this pull request:

compiled-dll-abbafb2d90a00ac1c230085a306367dca2130052.zip
These artifacts will expire in 90 days and will not be available for download after that time.

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

tyuah8 · 2024-09-26T03:38:46Z

Added customizable vertical health bars in form of HealthBarTypes. By default, technos use their own vanilla healthbars. Adding CustomHealthBarType changing health bar to this type. Can be applied to buildings.

Example

[HealthBarTypes]                                                       ; section in rulesmd.ini
0=HEALTHBAR1

[HEALTHBAR1]
Frame.Background=PIPBRD                                      ; shp file for use as background, first frame
Frame.Background.Translucency=0                           ; background translucency level
Frame.Background.ShowWhenNotSelected=false    ; should background be drawn, when ponting on techno
Frame.Foreground=                                                   ; shp file for use as foreground (drawn after health sections), first frame
Frame.Foreground.ShowWhenNotSelected=false     ; should foreground be drawn, when ponting on techno
HealthBar.OffsetX=0                                                  ; horizontal offset, similar to PixelSelectionBracketDelta
Sections.Pips=16,17,18                                              ; frames of pips.shp to use (green, yellow, red states)
Sections.Amount=17                                                 ; amount of sections, when bar is full
Sections.Size=2                                                          ; size in px of individual section

[SOMETECHNO]
CustomHealthBarType=HEALTHBAR1

No docs for now, needs testing.

Those voxels are quite nice and seem to resemble the look and feel of the original game voxels. Did you make those voxels yourself?

Fryone · 2024-09-26T03:43:08Z

Those voxels are quite nice and seem to resemble the look and feel of the original game voxels. Did you make those voxels yourself?

yep

NetsuNegi · 2024-09-26T12:02:29Z

nice feature for epic vehicle/airship/battleship :)

Metadorius · 2024-09-26T17:27:35Z

Custom Health Bar

Metadorius · 2024-09-26T17:32:11Z

Couple of suggestions on the general API stuff:
[HealthBarTypes] => [BarTypes]
In general I propose to treat this as a "custom anything bar" which can be used for HP bars.

For technos the tag should be CustomHealthBarType => HealthBar, less redundancy and more in-line with other things.

I think shields should use that too.

Metadorius · 2024-09-26T17:33:55Z

P.S. Can you do any shape/direction bars this way? I think it's a matter of making the section offset customizable in two dimensions, this way you could specify the 2,2 offset and have the bar go diagonal for example.

Fryone · 2024-09-26T18:00:07Z

P.S. Can you do any shape/direction bars this way? I think it's a matter of making the section offset customizable in two dimensions, this way you could specify the 2,2 offset and have the bar go diagonal for example.

The horizontal (vanilla like) bars were first in mind. I understand vertical ones, but diagonal...

Metadorius · 2024-09-26T18:03:29Z

The horizontal (vanilla like) bars were first in mind. I understand vertical ones, but diagonal...

It's only an example. The point is that if one can specify offset between sections in 2 dimensions then they can come up with whatever weird graphics they want, including diagonal bars, sectioned graphics etc.

Fryone · 2024-09-26T18:06:42Z

I think, I probably should make some "BarMaker" then, like procedure to draw by position and type.

chaserli · 2024-09-27T15:37:12Z

#1287 #1309 #1395
#1287 (comment)
If you are making a bar, generalize it to cover all fractionable quantities. HP/SP are just a small part of them. Some should display regardless of mouse hovering/selected.

Fryone · 2024-09-27T15:41:57Z

#1287 #1309 #1395 #1287 (comment) If you are making a bar, generalize it to cover all fractionable quantities. HP/SP are just a small part of them. Some should display regardless of mouse hovering/selected.

yeah, so the bars can be used to draw without hovering/selecting. i'm just using bar-drawer in the vanilla health part code. So it behaves like vanilla health bar.

chaserli · 2024-09-27T15:46:05Z

yeah, so the bars can be used to draw without hovering/selecting. i'm just using bar-drawer in the vanilla health part code. So it behaves like vanilla health bar.

I mean you can go more aggressive than that, just replace all 4 DrawHealthBar vtbl calls and handle it as well as other things in drawextras.

- added emptypip - added draw direction - added border offset - changed overall logic

src/Ext/Techno/Body.Visuals.cpp

src/New/Type/BarTypeClass.h

src/Ext/Techno/Body.Visuals.cpp

src/New/Type/BarTypeClass.h

src/Ext/Techno/Hooks.Pips.cpp

src/Ext/Techno/Body.Visuals.cpp

src/Ext/Techno/Body.h

src/Ext/Techno/Body.Visuals.cpp

Metadorius · 2024-09-28T20:09:58Z

src/New/Type/BarTypeClass.h

+	Nullable<TranslucencyLevel> BoardBG_Translucency;
+	Nullable<SHPStruct*> BoardFG_File;
+	Valueable<bool> BoardFG_ShowWhenNotSelected;
+	Nullable<TranslucencyLevel> BoardFG_Translucency;
+	Valueable<Vector2D<int>> Board_Offset;


Not sure why translucency flags are nullable here when they can just be valueables with default 0?

ZivDero · 2024-09-28T20:21:00Z

Also, you're hooking into the function. But the vanilla function is just one big if-else, and you hook both of the branches. You should replace the entire function.

Additionally, your hooks disable other Phobos hooks (shield bars, HeathBar.Height, digital displays). As such, you should move those patches into your replaced function, too.

Metadorius · 2024-11-11T07:30:05Z

@Fryone is there anything blocking you from fulfilling the requested changes?

Fryone · 2024-11-11T07:38:52Z

@Fryone is there anything blocking you from fulfilling the requested changes?

Nothing, I just need to get it. I just need to do it.

Co-authored-by: Kerbiter <[email protected]>

- hook refactor - Healthbar.Hide moved to healthbar hook - applied some suggested changes - added ability to choose file for bar pips - added ShieldBar.BarType TO DO: - for now, ShieldBar.BarType dont work without HealthBar.BarType

Metadorius · 2024-11-24T19:39:16Z

src/Ext/Techno/Hooks.Pips.cpp

+	int length = pThisIsInf ? 8 : 17;
+
+	if (pThisIsBld)
+	{
+		position.Y -= (static_cast<BuildingClass*>(pThis)->Type->Height + 1) * Unsorted::CellHeightInPixels / 2;
+		const int pThisBldTypeWidth = static_cast<BuildingClass*>(pThis)->Type->GetFoundationWidth();
+		length = pThisBldTypeWidth * 7 + (pThisBldTypeWidth / 2);
+	}
+	else
+	{
+		position.Y -= pThisIsInf ? 25 : 26;


Should add constants from here to YRpp (I think) to improve readability

…types

- changed blitterflags - updated logic with latest hook movements - shield and health bars can be used separately

CrimRecya · 2025-03-11T04:30:57Z

A practical feature, let me share my ideas.
Can we consider a similar approach to DigitalDisplayType, no longer confined to individual HealthBar.BarType or ShieldBar.BarType, but using InfoType in BarType to define what values to display?
In addition, can we encapsulate the drawing functions that mimic the vanilla style to reserve some space for future additions of different drawing methods (such as custom grid spacing, sharing the same grid, or even a single shp)?

Metadorius · 2025-04-19T09:01:20Z

@Fryone any response on the comments?

Fryone · 2025-04-19T09:05:44Z

I'm thinking if I should just finish whats done without any new logic changes (which is yrpp constants and docs)

Metadorius · 2025-04-19T09:18:03Z

I'm thinking if I should just finish whats done without any new logic changes (which is yrpp constants and docs)

On the InfoType: while I am not sure which approach is better, I do agree that it would be better to have this part common between digital displays and bars. Essentially, bars and digital displays do the same thing but in a bit different way, so they should be similar in use.

From what I understood, @CrimRecya (and previously @chaserli too) suggest a unified way to draw all such indicators and a "framework" of sorts, which is pretty logical.

CrimRecya · 2025-04-19T09:35:29Z

If possible, I also believe that #1422 is the best solution. But it requires a lot of effort, so I would like to ask for your opinion. Can you help complete this framework? if you don't have that much time either, perhaps we can also consider merging this pr first and modifying it in the future and using the migration document.

Fryone · 2025-04-19T09:45:15Z

the idea:

[InfoDisplayTypes]
DisplayFormatType= ; BarType / DigitalDisplayType
InfoType= ; Displayed value enumeration (health|shield|ammo|mindcontrol|spawns|passengers|tiberium|experience|occupants|gattlingstage)
//all positioning and visibility related stuff//

CrimRecya · 2025-04-19T09:53:19Z

I prefer to use separated BarType and DigitalDisplayType.
BarType may require some other drawing method, while DigitalDisplayType does not;
DigitalDisplayType may need to display like a timer, while BarType does not.
It's just that their data sources are all from InfoType.
For example, in this pr, simply change the data source to InfoType.
When no custom bars are defined, just use the default health and shield bar.
Then this PR can be included as a part of the framework.

…types

NetsuNegi · 2025-04-21T00:54:15Z

Considering that the vanillia filename is called "pips.shp", "pipbrd.shp", maybe it's better to use PipBrd and Pips instead of BoardBG and Section

Coronia · 2025-06-23T09:55:06Z

from design perspective #1635 is clearer and more universal, but since that one is closed, I think we should tweak this PR a bit to make it use generic Pip tags, instead of BoardBG/FG which is kinda hard to be understood and can't be extended to other type of bars in the future

Metadorius · 2025-06-23T10:13:35Z

from design perspective #1635 is clearer and more universal

Can you list what specifically needs improvement with examples? I think @Fryone could incorporate @NetsuNegi's improvements over this PR, or @NetsuNegi could submit some changes as he has edit rights as a maintainer.

Fryone · 2025-06-23T10:39:24Z

I already changed tag names, just not uploaded it here. Plus, there is something that using any shield bar type would crash game.

…types

- changed logic and namings - shields does not work - some problems with value calculations

Fryone · 2025-06-23T19:28:58Z

latest look

[BarTypes] ; section in rulesmd.ini
0=HEALTHBAR1

[HEALTHBAR1]
InfoType
PipBrd.Background.File= ; filename - without the .shp extension, image for use as background, first frame
PipBrd.Background.ShowWhenNotSelected=false ; boolean, should background be drawn, when ponting on techno
PipBrd.Background.Translucency= ; translucency level (0/25/50/75), background image translucency level
PipBrd.Foreground.File= ; filename - without the .shp extension, image for use as foreground (drawn after health sections), first frame
PipBrd.Foreground.ShowWhenNotSelected=false ; boolean, should foreground be drawn, when ponting on techno
PipBrd.Foreground.Translucency= ; translucency level (0/25/50/75), foreground image translucency level
PipBrd.Offset=0,0 ; X,Y, offset of background and foreground boards images
Bar.Offset=0,0 ; X,Y, offset of whole bar
Pips.File= ; filename - without the .shp extension, image to take frames from
Pips.Frames=16,17,18 ; list of 3 integers, frames of pips.shp to use (green, yellow, red states)
Pips.EmptyFrame=-1 ; integer, frame in pips.shp to use for empty section
Pips.Amount=17 ; integer, amount of sections, when bar is full
Pips.PositionDelta=2,0 ; X,Y, increment in pixels to next section
Pips.DrawBackwards=false ; boolean, changes order of drawing from last to first

[AudioVisual]
Buildings.DefaultBarTypes= ;list of bar types
Infantry.DefaultBarTypes= ;list of bar types
Vehicles.DefaultBarTypes= ;list of bar types
Aircraft.DefaultBarTypes= ;list of bar types

[SOMETECHNO]
BarTypes= ;list of bar types

Fryone · 2025-06-23T19:30:48Z

Planned:

Proper calculations;
Adding "DrawEmptyBar" for some infotypes;
Adding support for new infotypes;
Fixing bars for shields.

custom health bar types

514420d

Initial commit

Fryone changed the title ~~Custom Health Bars~~ Customizable Bars of Health Points Sep 26, 2024

changed to BarTypes

35350e4

- added emptypip - added draw direction - added border offset - changed overall logic

ZivDero requested changes Sep 28, 2024

View reviewed changes

Metadorius requested changes Sep 28, 2024

View reviewed changes

Metadorius assigned ZivDero and Metadorius Sep 28, 2024

Starkku force-pushed the develop branch from 31f2f2a to 804eadb Compare October 31, 2024 12:48

chaserli mentioned this pull request Nov 11, 2024

[Framework] Rework Extras draw #1422

Closed

Fryone and others added 5 commits November 16, 2024 18:13

Update src/Ext/Techno/Body.Visuals.cpp

89c0cfb

Co-authored-by: Kerbiter <[email protected]>

Update src/Ext/Techno/Body.Visuals.cpp

da0e53d

Co-authored-by: Kerbiter <[email protected]>

Update src/Ext/Techno/Hooks.Pips.cpp

df0c9a0

Co-authored-by: Kerbiter <[email protected]>

Update src/Ext/Techno/Hooks.Pips.cpp

4dd8b34

Co-authored-by: Kerbiter <[email protected]>

Update src/Ext/Techno/Body.Visuals.cpp

39b2679

Co-authored-by: Kerbiter <[email protected]>

Fryone and others added 5 commits November 16, 2024 18:15

Update src/Ext/Techno/Body.Visuals.cpp

496f884

Co-authored-by: Kerbiter <[email protected]>

Update src/Ext/Techno/Hooks.Pips.cpp

d41b3c1

Co-authored-by: Kerbiter <[email protected]>

Update src/Ext/Techno/Hooks.Pips.cpp

1519333

Co-authored-by: Kerbiter <[email protected]>

Update src/Ext/Techno/Hooks.Pips.cpp

7cd1aae

Co-authored-by: Kerbiter <[email protected]>

Rework 1

35111af

- hook refactor - Healthbar.Hide moved to healthbar hook - applied some suggested changes - added ability to choose file for bar pips - added ShieldBar.BarType TO DO: - for now, ShieldBar.BarType dont work without HealthBar.BarType

Metadorius reviewed Nov 24, 2024

View reviewed changes

Fryone added 2 commits December 7, 2024 16:27

Merge remote-tracking branch 'upstream/develop' into fryone/healthbar…

08d29ff

…types

rework update

f169caa

- changed blitterflags - updated logic with latest hook movements - shield and health bars can be used separately

DeathFishAtEase force-pushed the develop branch from 2128644 to 799ea22 Compare February 28, 2025 16:36

ZivDero force-pushed the develop branch from b2255d5 to a2da2a8 Compare March 7, 2025 22:38

Fryone mentioned this pull request Apr 19, 2025

[Highly Customized] Universal customize health bar #1635

Closed

Merge remote-tracking branch 'upstream/develop' into fryone/healthbar…

107ec11

…types

Starkku force-pushed the develop branch from f0d2dba to 2bba7c3 Compare May 16, 2025 19:25

Fryone added 2 commits June 23, 2025 21:49

Merge remote-tracking branch 'upstream/develop' into fryone/healthbar…

b3cf904

…types

latest state

aa17db5

- changed logic and namings - shields does not work - some problems with value calculations

Starkku force-pushed the develop branch 2 times, most recently from b429215 to 280b1c8 Compare June 29, 2025 19:13

Uh oh!

Customizable Bars of Health Points #1395

Are you sure you want to change the base?

Customizable Bars of Health Points #1395

Conversation

Fryone commented Sep 25, 2024 • edited by Belonit Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tyuah8 commented Sep 26, 2024

Uh oh!

Fryone commented Sep 26, 2024

Uh oh!

NetsuNegi commented Sep 26, 2024

Uh oh!

Metadorius commented Sep 26, 2024

Uh oh!

Metadorius commented Sep 26, 2024

Uh oh!

Metadorius commented Sep 26, 2024

Uh oh!

Fryone commented Sep 26, 2024

Uh oh!

Metadorius commented Sep 26, 2024

Uh oh!

Fryone commented Sep 26, 2024

Uh oh!

chaserli commented Sep 27, 2024

Uh oh!

Fryone commented Sep 27, 2024

Uh oh!

chaserli commented Sep 27, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Metadorius Sep 28, 2024

Choose a reason for hiding this comment

Uh oh!

ZivDero commented Sep 28, 2024

Uh oh!

Metadorius commented Nov 11, 2024

Uh oh!

Fryone commented Nov 11, 2024

Uh oh!

Metadorius Nov 24, 2024

Choose a reason for hiding this comment

Uh oh!

CrimRecya commented Mar 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Metadorius commented Apr 19, 2025

Uh oh!

Fryone commented Apr 19, 2025

Uh oh!

Metadorius commented Apr 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CrimRecya commented Apr 19, 2025

Uh oh!

Fryone commented Apr 19, 2025

Uh oh!

CrimRecya commented Apr 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NetsuNegi commented Apr 21, 2025

Uh oh!

Fryone commented Sep 25, 2024 •

edited by Belonit

Loading

github-actions bot commented Sep 25, 2024 •

edited

Loading

CrimRecya commented Mar 11, 2025 •

edited

Loading

Metadorius commented Apr 19, 2025 •

edited

Loading

CrimRecya commented Apr 19, 2025 •

edited

Loading