Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Select allied country units that have been cloaked #1389

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

[BugFix] Select allied country units that have been cloaked #1389

wants to merge 3 commits into from
+71 −0

Conversation

a851903106
Copy link

Phobos allow the player to observe friendly units that have been cloaked, but they cannot be selected unless a unit with Sensors=yes is present nearby.
bug

So I made a short fix to select units with Sensors=yes even if they don't exist nearby.
fix

@a851903106 a851903106 changed the title [Simple Fix] Select Friendly Units that have been Cloaked [Simple Fix] Select Friendly Units that have been cloaked Sep 21, 2024
@a851903106 a851903106 changed the title [Simple Fix] Select Friendly Units that have been cloaked Select allied country units that have been cloaked Sep 21, 2024
@a851903106 a851903106 changed the title Select allied country units that have been cloaked [BugFix] Select allied country units that have been cloaked Sep 22, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 23, 2024 •
edited
Loading

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

MortonPL
MortonPL requested changes Sep 23, 2024
View reviewed changes
Copy link
Member

@MortonPL MortonPL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I've run it and it looks like it also fixes a campaign bug with multiple player houses and uncontrollable stealth units.

From modified all01md.map:
image

Remember to add an entry in docs/Whats-New.md, CREDITS.md and docs/Fixed-or-Improved-Logics.md (bugfixes section). Once that's done, this PR can be merged.

src/Ext/House/Body.cpp Outdated Show resolved Hide resolved
src/Ext/Techno/Hooks.Cloak.cpp Outdated Show resolved Hide resolved
src/Ext/Techno/Hooks.Cloak.cpp Outdated Show resolved Hide resolved
@chaserli chaserli added Already implemented Merged / Handled by older PR / Handled in Ares or Spawner and removed Fix and merge this labels Sep 23, 2024
@chaserli
Copy link
Contributor

Partially already implemented, partially in another PR

CnCNet/yrpp-spawner#20
https://github.com/CnCNet/yrpp-spawner/blob/main/src/Misc/Observers.Visibility.cpp

@Metadorius
Copy link
Member

So uhh what are we doing with this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MortonPL MortonPL MortonPL approved these changes

Assignees

@chaserli chaserli

@MortonPL MortonPL

Labels
Already implemented Merged / Handled by older PR / Handled in Ares or Spawner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@a851903106 @chaserli @Metadorius @MortonPL