Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor] Shield respawn anim and weapon #1381

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Coronia
Copy link
Contributor

@Coronia Coronia commented Sep 16, 2024

  • Respawn.Anims, if set, will be played when the shield respawns. If more than one animation is listed, a random one is selected.
  • Respawn.Weapon, if set, will be fired at the TechnoType once the shield respawns.
  • Shield.Respawn.Anims and Shield.Respawn.Weapon override Respawn.Anims and Respawn.Weapon for duration of Shield.Respawn.Duration amount of frames.

In rulesmd.ini:

[SOMESHIELDTYPE]                            ; ShieldType name
Respawn.Anims=                              ; list of Animation
Respawn.Weapon=                             ; WeaponType

[SOMEWARHEAD]                               ; WarheadType
Shield.Respawn.Anims=                       ; list of Animation
Shield.Respawn.Weapon=                      ; WeaponType

@github-actions github-actions bot added the Minor Documentation is not required label Sep 16, 2024
Copy link

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

Copy link
Member

@Metadorius Metadorius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose to add a common template/composite tag like Promotable to which people can assign whatever they want - anim, weapon or whatever. The point is that we can reuse this template anywhere and easily add a lot of events, all consistently.

@Metadorius Metadorius self-assigned this Sep 16, 2024
@Starkku
Copy link
Contributor

Starkku commented Sep 16, 2024

I propose to add a common template/composite tag like Promotable to which people can assign whatever they want - anim, weapon or whatever. The point is that we can reuse this template anywhere and easily add a lot of events, all consistently.

And this template does what exactly?

@Metadorius
Copy link
Member

I propose to add a common template/composite tag like Promotable to which people can assign whatever they want - anim, weapon or whatever. The point is that we can reuse this template anywhere and easily add a lot of events, all consistently.

And this template does what exactly?

Almost-one-liner for modders to add whatever amounts of event handling possibilities for any "event" in a consistent fashion, like I do have those in techno attachment and I can just use the template. Further on it can be expanded to add whatever event handling possibilities if needed.
image

@MortonPL MortonPL added Needs Rework The structure or methodology is "mise en question" and removed Minor Documentation is not required labels Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Rework The structure or methodology is "mise en question"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants