Penetration damage on garrisonable structures #1370

FS-21 · 2024-08-30T11:50:25Z

Warheads can now damage garrisoned infantry at impact.
PenetratesGarrison Enables the logic.
- PenetratesGarrison.RandomTarget specifies if the damage will go at some random garrisoned soldier or if all infantry should be damaged at the same time.
- PenetratesGarrison.DamageMultiplier can be used to modify the damage applied against the garrisoned infantry. A random percentage value will be picked between the specified range.
- PenetratesGarrison.CleanSound can be used to specify a sound to play when the structure lost all the garrisoned soldiers with this logic.
- PenetratesGarrison.Allowed can be set on garrisonable buildings to protect the garrisoned infantry. If used on infantry these units won't affected by this logic.

In rulesmd.ini:

[SOMEWARHEAD]                                 ; WarheadType
PenetratesGarrison=false                      ; boolean
PenetratesGarrison.RandomTarget=true          ; boolean
PenetratesGarrison.DamageMultiplier=1.0,1.0   ; floating point value - single or comma-sep. range (percentages)
PenetratesGarrison.CleanSound=                ; sound entry

[SOMETECHNO]                                  ; TechnoType
PenetratesGarrison.Allowed=false              ; boolean

- Warheads can now damage garrisoned infantry at impact. - `GarrisonPenetration` Enables the logic. - `GarrisonPenetration.RandomTarget` specifies if the damage will go at some random garrisoned soldier or if all infantry should be damaged at the same time. - `GarrisonPenetration.DamageMultiplier` can be used to modify the damage applied against the garrisoned infantry. A random percentage value will be picked between the specified range. - `GarrisonPenetration.CleanSound` can be used to specify a sound to play when the structure lost all the garrisoned soldiers with this logic. - `ImmuneToGarrisonPenetration` can be set on garrisonable buildings to protect the garrisoned infantry. If used on infantry these units won't affected by this logic. In `rulesmd.ini`: [SOMEWARHEAD] ; Warhead GarrisonPenetration=false ; boolean GarrisonPenetration.RandomTarget=true ; boolean GarrisonPenetration.DamageMultiplier=1.0,1.0 ; floating point value - single or comma-sep. range (percentages) GarrisonPenetration.CleanSound= ; sound entry [SOMETECHNO] ; TechnoType ImmuneToGarrisonPenetration=false ; boolean

…-garrison

github-actions · 2024-08-30T11:54:27Z

Nightly build for this pull request:

compiled-dll-212b25bcfab57b1c4b7dfb00e01100896d7331f3.zip
These artifacts will expire in 90 days and will not be available for download after that time.

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

FS-21 · 2024-08-31T09:28:47Z

Reopened because I finally tested it online and is free of desyncs.

Fryone · 2024-09-15T17:19:01Z

Isn't it similar to Ares Pass Through? https://ares-developers.github.io/Ares-docs/new/buildings/urbancombattrenches.html
though, Ares did it through projectiles and buildings...

mevitar · 2024-09-18T00:32:16Z

There were some issues with that garrison logic that i do not remember right now, and this feature here might allow for better control over what can get cleared and what not.
If anything, this one is much more intuitive.

Coronia

suggest to change these tags' names into PenetratesGarrison, to keep consistent with the already exists PenetratesBunker tag

src/Ext/WarheadType/Detonate.cpp

Coronia · 2025-02-18T08:12:33Z

src/Ext/WarheadType/Detonate.cpp

+		damage = MapClass::GetTotalDamage(damage, pWH, pPassenger->Type->Armor, 0);
+
+		pPassenger->Health = pPassenger->Health - damage;
+		pPassenger->Health = pPassenger->Health < 0 ? 0 : pPassenger->Health;


merging these 2 lines into 1:

pPassenger->Health = Math::clamp(pPassenger->Health - damage, 0, pPassenger->Type->Strength);

pPassenger->Health = Math::clamp(pPassenger->Health - damage, 0, pPassenger->Type->Strength);

I don't understand the use of pPassenger->Type->Strength here.

since we're now supporting negative damage for PenetrateGarrison, this is for preventing it from gaining more health than its limit. It can be ignored if there're already some other sorts of check elsewhere tho

What I mean, since I never used that clamp method before:

Example:
Passenger->Health = 50
damage = -25 (healer example)
pPassenger->Type->Strength = 300

Current code:
Passenger->Health = 50 - (-25) = 75;
pPassenger->Health = 75 < 0 ? 0 : 75;

That new line for merging code:
pPassenger->Health = Math::clamp(75, 0, 300);
It does return "pPassenger->Health = 75" ? Just ignorant question

It does, clamp will return a value that's between minimum and maximum values, which are 0 and 300 in this case

But the right answer of the example is 75, not 300 that is the max health the unit can have :-/

From GarrisonPenetration to PenetratesGarrison

Coronia · 2025-05-12T06:00:38Z

src/Ext/WarheadType/Detonate.cpp

+		if (pTypeExt->ImmuneToPenetratesGarrison)
+			return;
+
+		damage = MapClass::GetTotalDamage(damage, pWH, pPassenger->Type->Armor, 0);


should consider distance between epicenter as well

They are infantry gathered together inside a structure, I don't understand the point :-/

it's about judging the distance between the warhead's detonation point and the garrisoned building, which is still necessary. Imagine the case when using a neutron bomb with large cellspread on these buildings, it's expected that infantry garrisoned in the edge should take less damage than those in the center

But you can't point at garrisoned infantry directly (maybe if the Techno Attachment is merged into develop, someday?).
If adding that change doesn't affect the current behaviour I'll check how is done in another part of the project and apply the suggested change here.

we can simply calculate the distance between the warhead's detonation point and the garrisoned building in this case

Not sure how should be done since I see no similar examples in Phobos.
Is this?

int distanceFromCenter = pTarget->DistanceFrom(pPassenger);
damage = MapClass::GetTotalDamage(damage, pWH, pPassenger->Type->Armor, distanceFromCenter);

or:

int distanceFromCenter = pBullet->DistanceFrom(pTarget);
damage = MapClass::GetTotalDamage(damage, pWH, pPassenger->Type->Armor, distanceFromCenter);

or:

int distanceFromCenter = pBullet->DistanceFrom(pPassenger);
damage = MapClass::GetTotalDamage(damage, pWH, pPassenger->Type->Armor, distanceFromCenter);

or none of the above?

should be the second one

src/Ext/WarheadType/Detonate.cpp

…es-garrison # Conflicts: # CREDITS.md # YRpp # src/Ext/TechnoType/Body.cpp # src/Ext/WarheadType/Detonate.cpp

FS-21 added 3 commits August 20, 2024 13:33

Merge remote-tracking branch 'origin/develop' into feature/penetrates…

9b4bf42

…-garrison

Fix typo

9c49632

FS-21 closed this Aug 30, 2024

FS-21 reopened this Aug 31, 2024

FS-21 added 2 commits October 27, 2024 21:47

Merge branch 'develop' into feature/penetrates-garrison

433f0f7

Merge branch 'develop' into feature/penetrates-garrison

02cd739

Starkku force-pushed the develop branch from 31f2f2a to 804eadb Compare October 31, 2024 12:48

Coronia requested changes Feb 18, 2025

View reviewed changes

Merge branch 'develop' into feature/penetrates-garrison

cfedc7a

DeathFishAtEase force-pushed the develop branch from 2128644 to 799ea22 Compare February 28, 2025 16:36

ZivDero force-pushed the develop branch from b2255d5 to a2da2a8 Compare March 7, 2025 22:38

Renaming tag

3ffa046

From GarrisonPenetration to PenetratesGarrison

Coronia reviewed May 12, 2025

View reviewed changes

Otamaa reviewed May 13, 2025

View reviewed changes

src/Ext/WarheadType/Detonate.cpp Outdated Show resolved Hide resolved

Starkku force-pushed the develop branch from f0d2dba to 2bba7c3 Compare May 16, 2025 19:25

FS-21 added 6 commits May 19, 2025 07:08

Merge branch 'develop' into feature/penetrates-garrison

416f941

Applied some feedback

19742ba

Merge branch 'develop' into feature/penetrates-garrison

a773290

Merge branch 'develop' into feature/penetrates-garrison

053ae2a

Merge branch 'develop' into feature/penetrates-garrison

41e953d

Merge branch 'develop' into feature/penetrates-garrison

81e2820

Starkku force-pushed the develop branch 2 times, most recently from b429215 to 280b1c8 Compare June 29, 2025 19:13

Merge remote-tracking branch 'upstream/develop' into feature/penetrat…

7809074

…es-garrison # Conflicts: # CREDITS.md # YRpp # src/Ext/TechnoType/Body.cpp # src/Ext/WarheadType/Detonate.cpp

Coronia force-pushed the feature/penetrates-garrison branch from feba95c to 7809074 Compare July 8, 2025 15:02

Coronia added Needs testing ⚙️T1 T1 maintainer review is sufficient labels Jul 8, 2025

fix distance calculation

c62028a

Uh oh!

Penetration damage on garrisonable structures #1370

Are you sure you want to change the base?

Penetration damage on garrisonable structures #1370

Conversation

FS-21 commented Aug 30, 2024 • edited by Coronia Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Aug 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

FS-21 commented Aug 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Fryone commented Sep 15, 2024

Uh oh!

mevitar commented Sep 18, 2024

Uh oh!

Coronia left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Coronia Feb 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

FS-21 May 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

FS-21 May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

FS-21 May 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

FS-21 commented Aug 30, 2024 •

edited by Coronia

Loading

github-actions bot commented Aug 30, 2024 •

edited

Loading

FS-21 commented Aug 31, 2024 •

edited

Loading

Coronia Feb 18, 2025 •

edited

Loading

FS-21 May 19, 2025 •

edited

Loading

FS-21 May 29, 2025 •

edited

Loading

FS-21 May 19, 2025 •

edited

Loading