Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Insignia.Weapon failed to parse in map & Insignia.Passengers #1365

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Coronia
Copy link
Contributor

@Coronia Coronia commented Aug 25, 2024

previous Insignia(.Frame/.Frames).WeaponN settings can't be read or overridden from maps, which is fixed now

also added insignia based on current passenger size: Normal insignia can be overridden when its current passenger size reaches a certain amount by setting Insignia(.Frame/.Frames).PassengersN where N stands for the current passenger size amount. If not set, defaults to non-passenger specific insignia settings. Will be overridden by weapon mode insignia settings, if set.

In rulesmd.ini:

Insignia.PassengersN=                    ; filename - excluding the .shp extension
Insignia.PassengersN.Rookie=             ; filename - excluding the .shp extension
Insignia.PassengersN.Veteran=            ; filename - excluding the .shp extension
Insignia.PassengersN.Elite=              ; filename - excluding the .shp extension
InsigniaFrame.PassengersN=-1             ; int, frame of insignia shp (zero-based) or -1 for default
InsigniaFrame.PassengersN.Rookie=-1      ; int, frame of insignia shp (zero-based) or -1 for default
InsigniaFrame.PassengersN.Veteran=-1     ; int, frame of insignia shp (zero-based) or -1 for default
InsigniaFrame.PassengersN.Elite=-1       ; int, frame of insignia shp (zero-based) or -1 for default
InsigniaFrames.PassengersN=-1,-1,-1      ; int, frames of insignia shp (zero-based) or -1 for default

Copy link

github-actions bot commented Aug 25, 2024

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

Copy link
Contributor

@Starkku Starkku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly fine, a couple of questions about some things though.

src/Ext/TechnoType/Body.cpp Outdated Show resolved Hide resolved
docs/Fixed-or-Improved-Logics.md Outdated Show resolved Hide resolved
CREDITS.md Outdated Show resolved Hide resolved
@Coronia Coronia force-pushed the passenger-insignia branch 4 times, most recently from c13f240 to f7aaf66 Compare September 16, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants