Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow voxel bullet to use AnimPalette and FirersPalette #1353

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

NetsuNegi
Copy link
Contributor

It just a bugfix.

Copy link

github-actions bot commented Aug 13, 2024

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

Copy link
Member

@MortonPL MortonPL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay. Has it been tested?

CREDITS.md Outdated Show resolved Hide resolved
docs/Fixed-or-Improved-Logics.md Outdated Show resolved Hide resolved
docs/Whats-New.md Outdated Show resolved Hide resolved
src/Misc/Hooks.BugFixes.cpp Outdated Show resolved Hide resolved
src/Misc/Hooks.BugFixes.cpp Outdated Show resolved Hide resolved
@MortonPL MortonPL self-assigned this Sep 24, 2024
@MortonPL MortonPL added the Fixed / Improved Logic Minor stuff label Sep 24, 2024
@NetsuNegi
Copy link
Contributor Author

Looks okay. Has it been tested?

It seems that no one else has tested it yet.

@mevitar
Copy link

mevitar commented Sep 27, 2024

AnimPalette=yes works.
FirersPalette=yes/no, i'm not sure how is it supposed to work, as i don't see any difference. Whether the firer uses regular palette or has its own (through the Palette= tag), the results are the same and the projectiles use the regular unit palette.

@NetsuNegi
Copy link
Contributor Author

AnimPalette=yes works. FirersPalette=yes/no, i'm not sure how is it supposed to work, as i don't see any difference. Whether the firer uses regular palette or has its own (through the Palette= tag), the results are the same and the projectiles use the regular unit palette.

I just want make voxel bullets can remap firer house color XD.

@mevitar
Copy link

mevitar commented Sep 28, 2024

I just want make voxel bullets can remap firer house color XD.

I tried that too, it didn't work. Projectiles did not remap properly.
They do not remap in the newest build either.

When he was working on making animations remapable, Starkku mentioned something about objects using two ways of color/palette handling, and only one of those allows for remapable colors (i don't remember the details, though).
If you didn't do that already, you might have to make voxel projectiles use that other method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants