Projectile subject to ground check before firing #1291
+106
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
Coronia
suggested changes
Aug 15, 2024
src/Ext/Bullet/Hooks.Obstacles.cpp
Outdated
|
|
||
| const int extraHeight = pTechno->GetHeight(); | ||
|
|
||
| if (extraHeight > 200) |
There was a problem hiding this comment.
height for a cell is 208, which is used by vanilla as the condition of air and ground. This one should probably be changed as well
| const int passengerIndex = -weaponIndex - 1; | ||
|
|
||
| for (int i = 0; i < passengerIndex && currentPassenger; i++) | ||
| currentPassenger = abstract_cast<FootClass*>(currentPassenger->NextObject); |
There was a problem hiding this comment.
for (int i = 0; i < passengerIndex && currentPassenger; i++)
{
currentPassenger = abstract_cast<FootClass*>(currentPassenger->NextObject);
}
There was a problem hiding this comment.
I think it's not necessary because it's only one line here and it's clear enough
docs/New-or-Enhanced-Logics.md
Outdated
| @@ -683,6 +683,7 @@ Shrapnel.UseWeaponTargeting=false ; boolean | |||
|
|
|||
| - It is now possible to make projectiles consider either land or water as obstacles that block their path by setting `SubjectToLand/Water` to true, respectively. Weapons firing such projectiles will consider targets blocked by such obstacles as out of range and will attempt to reposition themselves so they can fire without being blocked by the said obstacles before firing and if `SubjectToLand/Water.Detonate` is set to true, the projectiles will detonate if they somehow manage to collide with the said obstacles. | |||
| - `Level=true` projectiles detonate on tiles belonging to non-water tilesets by default, but will not consider such tiles as true obstacles. This behaviour can be overridden by setting these keys. | |||
| - As for `SubjectToGround`, if set it to true ,it will predict will predict the height of the connecting straight line from the bullet's source coordinates to target coordinates. If the predicted height is lower than the ground height of the current predicted position, the firer will also consider targets blocked by such obstacles as out of range and will attempt to reposition themselves. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a feature split from #1261 .
It may have similarities with other parts.
If set
SubjectToGroundto true ,it will predict will predict the height of the connecting straight line from the bullet's source coordinates to target coordinates. If the predicted height is lower than the ground height of the current predicted position, the firer will also consider targets blocked by such obstacles as out of range and will attempt to reposition themselves.In
rulesmd.ini: