Starkku's pip additions: Empty frame for Tiberiums #1138
Conversation
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
|
I personally think the empty frame should be defined separately since this is how it currently works on the techno-specific Pip keys (and in a manner of speaking, for shield etc. pips since the pip board can be set separately) but this is a very minor gripe and ultimately W/E. |
separated empty frame from the list
WalkthroughThe update primarily focuses on refining the visual representation and configuration of Tiberium pips within the game. It includes removing an unnecessary extension from the development environment, adjusting the default settings and display order for Tiberium pips, and enhancing the code to better manage these visual elements. The modifications span across documentation, configuration files, and source code to ensure a more customizable and visually appealing depiction of Tiberium-related elements. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (5)
- .vscode/extensions.json (1 hunks)
- docs/Fixed-or-Improved-Logics.md (2 hunks)
- src/Ext/Rules/Body.cpp (2 hunks)
- src/Ext/Rules/Body.h (2 hunks)
- src/Ext/Techno/Hooks.Pips.cpp (2 hunks)
Files skipped from review due to trivial changes (2)
- .vscode/extensions.json
- src/Ext/Rules/Body.h
Additional comments: 5
src/Ext/Rules/Body.cpp (2)
98-104: The new INI setting
Pips.Tiberiums.EmptyFrameis correctly loaded from the INI file. This change aligns with the pull request's goal to enhance the visual representation of Tiberium pips. Ensure that the default value for this setting is documented and that it does not conflict with existing frame indices.233-239: The serialization process has been updated to include the new
Pips_Tiberiums_EmptyFramevariable. This is necessary to ensure that the new setting is saved and loaded correctly. Verify that the serialization process is tested and that the new setting is correctly handled during save/load operations.docs/Fixed-or-Improved-Logics.md (2)
- 540-545: The documentation correctly reflects the new configuration options for Tiberium pips, including the addition of an empty frame. This change should be verified in the actual INI files to ensure the default values are set as described here.
---start hunk 1---
- 550-555: The documentation update is clear and provides the necessary information for modders to understand the new configuration options for Tiberium pips. It's important to ensure that the
rulesmd.inifile is updated accordingly to support these new features.src/Ext/Techno/Hooks.Pips.cpp (1)
- 177-182: ```
---end hunk 0---
The initialization offramewith `Pips_Tiberiums_EmptyFrame` is correct, ensuring that if no Tiberium is present, the empty frame is used.---start hunk 1---
</blockquote></details></blockquote></details> </details>
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (4)
- docs/Fixed-or-Improved-Logics.md (2 hunks)
- src/Ext/Rules/Body.cpp (2 hunks)
- src/Ext/Rules/Body.h (2 hunks)
- src/Ext/Techno/Hooks.Pips.cpp (1 hunks)
Files skipped from review due to trivial changes (1)
- src/Ext/Techno/Hooks.Pips.cpp
Additional comments: 6
src/Ext/Rules/Body.h (2)
68-68: The new member variable
Pips_Tiberiums_EmptyFrameis correctly added to theRulesExtclass. It is initialized with a default value of 0, which is consistent with the pull request summary stating that the empty frame should be the first integer value in the sequence.139-139: The constructor of
ExtDatais updated to initialize the new member variablePips_Tiberiums_EmptyFramewith a default value of 0. This is in line with the changes described in the pull request summary.src/Ext/Rules/Body.cpp (2)
99-105: The new INI setting
Pips.Tiberiums.EmptyFrameis correctly loaded from the INI file. This change should be cross-checked with the documentation and in-game behavior to ensure that the new frame index is being applied correctly to the Tiberium pips visualization.238-243: The serialization of the new
Pips_Tiberiums_EmptyFramesetting is included, which ensures that the value is saved and loaded correctly. This is important for maintaining game settings consistency across sessions.docs/Fixed-or-Improved-Logics.md (2)
562-567: The changes to
Pips.Tiberiums.FramesandPips.Tiberiums.DisplayOrderare significant for the visual representation of Tiberium storage on units. The addition of an empty frame at the beginning of thePips.Tiberiums.Frameslist is a notable change that should be reflected in the game's UI. It is important to ensure that the game's logic for displaying Tiberium pips is updated to accommodate this new frame sequence. Additionally, the change in the configuration file location from[AudioVisual]torulesmd.inishould be verified to ensure that it does not conflict with any existing settings or mods that may rely on the previous configuration location.572-577: The changes to the
Pips.Generic.Buildings.Size,Pips.Ammo.Size,Pips.Ammo.Buildings.Size,Pips.Tiberiums.Frames, andPips.Tiberiums.DisplayOrdersettings are refinements that affect how various pips are displayed in the game. It is important to verify that these changes are consistent with the intended visual design and that they do not introduce any unexpected behavior in the display of pips for different Tiberium types, ammo, and generic pips for buildings and units. The use of specific frames for different Tiberium types and the order of display should be carefully reviewed to ensure they meet the game's design requirements.
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- docs/Fixed-or-Improved-Logics.md (2 hunks)
Additional comments: 1
docs/Fixed-or-Improved-Logics.md (1)
- 563-567: The documentation correctly reflects the changes made to the
Pips.Tiberiums.Framesconfiguration, including the addition of an empty frame first and the adjustment of the order of Tiberium type pips. This aligns with the PR objectives and the AI-generated summary of changes.
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- docs/Fixed-or-Improved-Logics.md (2 hunks)
Additional comments: 1
docs/Fixed-or-Improved-Logics.md (1)
- 565-571: > Note: This review was outside the patches, so it was mapped to the patch with the greatest overlap. Original lines [568-578]
The documentation has been updated to reflect the new default values and behavior for
Pips.Tiberiums.FramesandPips.Tiberiums.DisplayOrder. This aligns with the PR objectives to enhance the visual representation of Tiberium pips.
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- docs/Fixed-or-Improved-Logics.md (2 hunks)
Additional comments: 1
docs/Fixed-or-Improved-Logics.md (1)
- 567-573: > Note: This review was outside the patches, so it was mapped to the patch with the greatest overlap. Original lines [570-580]
The addition of
Pips.Tiberiums.FramesandPips.Tiberiums.DisplayOrderto the documentation reflects the changes made to the configuration settings for Tiberium pips. This update should provide users with the necessary information to customize the pip frames and their display order for different Tiberium types, enhancing the visual customization capabilities of the game.
There was a problem hiding this comment.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (3)
- docs/Fixed-or-Improved-Logics.md (2 hunks)
- src/Ext/Rules/Body.cpp (2 hunks)
- src/Ext/Rules/Body.h (2 hunks)
Additional comments: 2
src/Ext/Rules/Body.h (1)
- 71-71: The addition of
Pips_Tiberiums_EmptyFramewith an initialization value of0is aligned with the PR's objectives to enhance Tiberium pip customization. However, consider Starkku's suggestion to define the empty frame separately for consistency with other techno-specific pip keys.src/Ext/Rules/Body.cpp (1)
- 245-245: The addition of
Pips_Tiberiums_EmptyFrameto the serialization process is correctly implemented and necessary for the new feature's functionality. This ensures that the customization options for Tiberium pips are correctly saved and loaded across game sessions.
Pips.Tiberiums.Frames=0,2,5,2,2 - added first int to be empty frame for tiberiums
Summary by CodeRabbit
StorageandTiberiumtypes.