Show designator & inhibitor range

[MortonPL]

• It is now possible to display range of designator and inhibitor units when in super weapon targeting mode. Each instance of player owned techno types listed in [SuperWeapon]->SW.Designators will display a circle with radius set in [TechnoType]->DesignatorRange or Sight.
  • In a similar manner, each instance of enemy owned techno types listed in [SuperWeapon]->SW.Inhibitors will display a circle with radius set in [TechnoType]->InhibitorRange or Sight.
• This feature can be disabled globally with [AudioVisual]->ShowDesignatorRange=false or per SuperWeaponType with [SuperWeapon]->ShowDesignatorRange=false.
• This feature can be toggled by the player (if enabled in the mod) with ShowDesignatorRange in Ra2MD.ini or with "Toggle Designator Range" hotkey in "Interface" category.

Due to technical reasons, this feature only works for super weapons with `Range` >= 1.

In rulesmd.ini:

[AudioVisual]
ShowDesignatorRange=true    ; boolean

[SOMESW]                    ; SuperWeapon
ShowDesignatorRange=true    ; boolean

In Ra2MD.ini:

[Phobos]
ShowDesignatorRange=false             ; boolean

[github-actions]

Nightly build for this pull request:

• compiled-dll-325861f76e52e49481c70b2fa98403ee2aad78c6.zip
  These artifacts will expire in 90 days and will not be available for download after that time.

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

[Starkku]

Not sure if both hotkey and user INI setting are needed for this, should probably pick one or the other. Although I guess if it is just hotkey it won't save the preference across sessions but if it is a feature where you'd want that then just having the user INI option is better anyway.

Code itself looks good, but it should really be extended to work with inhibitors too. Display the indicators in the inhibitor's owner's color. Not sure what would do when/if Suppressors/Attractors (friendly inhibitors and enemy designators) are added but that is a bridge that can be crossed then.

[Metadorius]

Considering those ranges only get displayed when you're firing a superweapon (btw does it only show relevant designators/inhibitors?) I don't think it's ever needed to be manually toggleable because it's not obstructive and it's kinda toggled automatically when firing the SW anyways.

[Starkku]

Due to technical reasons, this feature only works for super weapons with Range >= 1.

What technical reasons? I replaced your hook with:

DEFINE_HOOK(0x6DBE74, Tactical_SuperLinesCircles_ShowDesignatorRange, 0x7)
{
	if (!Phobos::Config::ShowDesignatorRange || !(RulesExt::Global()->ShowDesignatorRange) || Unsorted::CurrentSWType == -1)
		return 0;

	const auto pSuperType = SuperWeaponTypeClass::Array()->GetItem(Unsorted::CurrentSWType);
	const auto pExt = SWTypeExt::ExtMap.Find(pSuperType);

	if (!pExt->ShowDesignatorRange)
		return 0;

	for (const auto pCurrentTechno : *TechnoClass::Array)
	{
		const auto pCurrentTechnoType = pCurrentTechno->GetTechnoType();
		const auto pOwner = pCurrentTechno->Owner;

		if (!pCurrentTechno->IsAlive
			|| pCurrentTechno->InLimbo
			|| !pExt->SW_Designators.Contains(pCurrentTechnoType)
			|| !((pOwner == HouseClass::CurrentPlayer)
				|| EnumFunctions::CanTargetHouse(AffectedHouse::Enemies, HouseClass::CurrentPlayer, pOwner)))
		{
			continue;
		}

		const auto pTechnoTypeExt = TechnoTypeExt::ExtMap.Find(pCurrentTechnoType);

		const float radius = pOwner == HouseClass::CurrentPlayer ?
			(float)(pTechnoTypeExt->DesignatorRange.Get(pCurrentTechnoType->Sight)) :
			(float)(pTechnoTypeExt->InhibitorRange.Get(pCurrentTechnoType->Sight));

		CoordStruct coords = pCurrentTechno->GetCenterCoords();
		coords.Z = MapClass::Instance->GetCellFloorHeight(coords);
		const auto color = pOwner->Color;
		Game::DrawRadialIndicator(false, true, coords, color, radius, false, true);
	}

	return 0;
}

E.g move it to the start of the function and fetch the SW type yourself. And it appears to work just fine, only issue is that the hook will be entered much more often (idk if this is a major performance hog though) and minor redundancy in fetching the SW type potentially twice but this comes in exchange for working independently from SW's Range or the target lines option. Couple of minor optimizations with the checks / their order as well. Checking extension class pointers for nullptr is generally speaking futile exercise - ExtMap::Find will under most circumstances only now return nullptr if you call it with nullptr, in which case you're gonna have other problems anyway (missing type) and if it is not a pointer of correct type it'll just crash or return garbage regardless. Cost of performance is security I suppose.

[Metadorius]

LGTM after fixing