-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional desync logging #1098
Merged
Starkku
merged 10 commits into
Phobos-developers:develop
from
Starkku:feature/sync-logging
Jul 15, 2023
Merged
Additional desync logging #1098
Starkku
merged 10 commits into
Phobos-developers:develop
from
Starkku:feature/sync-logging
Jul 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
I think it's better to add a command line param switch, if this cause performence problem. |
Metadorius
reviewed
Jul 11, 2023
Metadorius
approved these changes
Jul 15, 2023
Starkku
force-pushed
the
feature/sync-logging
branch
from
July 15, 2023 10:41
ef7a940
to
6e9a598
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds following things, including relevant parameters, function caller/return address and current frame to be appended to
SYNC#.txt
log files upon desynchronization occuring:ScenarioClass
member)FacingClass::Set()
callsTechnoClass::AssignTarget()
calls (including overrides)TechnoClass::AssignDestination()
calls (including overrides)TechnoClass::OverrideMission()
callsAnimClass
constructor callsThese numbers can be amended later if needed. This feature is also currently enabled by default in multiplayer games only (the hooks that log this information are disabled in singleplayer/skirmish), and can incur a performance decrease. A toggle can be added later if needed.