Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional desync logging #1098

Merged
merged 10 commits into from
Jul 15, 2023

Conversation

Starkku
Copy link
Contributor

@Starkku Starkku commented Jul 7, 2023

This adds following things, including relevant parameters, function caller/return address and current frame to be appended to SYNC#.txt log files upon desynchronization occuring:

  • Last 4096 calls to game's synced random number generator function (the one that is ScenarioClass member)
  • Last 1024 FacingClass::Set() calls
  • Last 1024 TechnoClass::AssignTarget() calls (including overrides)
  • Last 1024 TechnoClass::AssignDestination() calls (including overrides)
  • Last 256 TechnoClass::OverrideMission() calls
  • Last 512 AnimClass constructor calls

These numbers can be amended later if needed. This feature is also currently enabled by default in multiplayer games only (the hooks that log this information are disabled in singleplayer/skirmish), and can incur a performance decrease. A toggle can be added later if needed.

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@NetsuNegi
Copy link
Contributor

I think it's better to add a command line param switch, if this cause performence problem.

@Starkku Starkku merged commit a7120c3 into Phobos-developers:develop Jul 15, 2023
4 of 5 checks passed
@Starkku Starkku deleted the feature/sync-logging branch July 15, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants