-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Units AutoDeploy/DeployBlock on Ammo change #1086
Units AutoDeploy/DeployBlock on Ammo change #1086
Conversation
TechnoType: OnAmmoDepletion.AutoDeploy OnAmmoDepletion.DeployBlock
removed unsuccesseful building support
This reverts commit 33c8a68.
Co-authored-by: MortonPL <[email protected]>
Co-authored-by: MortonPL <[email protected]>
Co-authored-by: MortonPL <[email protected]>
Co-authored-by: MortonPL <[email protected]>
Co-authored-by: MortonPL <[email protected]>
Co-authored-by: MortonPL <[email protected]>
Co-authored-by: MortonPL <[email protected]>
Co-authored-by: MortonPL <[email protected]>
Co-authored-by: MortonPL <[email protected]>
Suggested refactoring applied
Updated feature description
Credits and Changelog update
Co-authored-by: MortonPL <[email protected]>
OnAmmoDepletion_DeployBlock replaced with OnAmmoDepletion_DeployUnlockAmount
issue fixed, wrong condition
removed unnecessary functions
Implemented Hooks.Unload extension
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, a few minor style and documentation issues remain.
c8cc280
to
5548261
Compare
Added VoiceCantDeploy to signal that deploying is unavailable
added nodeploy cursor
Docs update Voice removed
…ne/Phobos into fryone/ammodepletion_deploy
Fixed Deploying on hotkey
- now autodeploy executes on exact amount of ammo - some renaming
Ammo.AddOnDeploy
- separate for deploying/undeploying and converting
…ammodepletion_deploy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would also be good to have this feature at both "sides" of the ammo count, as in instead of
specifying the minimal required amount you can also specify the maximum.
8b53ac1
to
fc296ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me !
Requires units to have:
'Ammo' > 0;
'IsSimpleDeployer=yes';
'Convert.Deploy='.
IsSimpleDeployer
vehicle auto-deploy / deploy block on ammo changeAmmo.AutoDeployMinimumAmount
determines the minimal number of ammo at which a vehicle converts/deploys automatically.Ammo.DeployUnlockMinimumAmount
determines the minimal number of ammo that unlocks issuing vehicle converting/deploying command.Ammo.AutoDeployMaximumAmount
andAmmo.DeployUnlockMaximumAmount
behave analogically.In
rulesmd.ini
:IsSimpleDeployer
vehicle ammo change on deployAmmo.AddOnDeploy
determines the number of ammo added or substracted on unit deploy.In
rulesmd.ini
: