Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use of kernel functions unavailable starting with v5.18 #12

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Schroedingers-Cat
Copy link

@Schroedingers-Cat Schroedingers-Cat commented Aug 6, 2022

This PR adds support for Linux Kernel v5.18 and higher which removed two deprecated functions.

I tested this with a HDSPe MADI on kernel versions 5.17, 5.18 and 5.19 on Manjaro.

@VennStone
Copy link

Works on the AIO Pro with 5.18.

@wolframd
Copy link

wolframd commented Jan 5, 2023

Hello LGCW,
which distro and desktop are you using? Compilation fails with me and kernel 5.19.0-26 as well. If your distro works fine with it, I consider changing (it's ubuntucinnamon now). Since the developer passed away quite young, I see no other way for me...
Thanks!
HDSPE Compilation fails with 5.19.txt

@Schroedingers-Cat
Copy link
Author

Do you have the kernel headers installed?

@wolframd
Copy link

wolframd commented Jan 5, 2023 via email

@Schroedingers-Cat
Copy link
Author

If you have those installed, can you double check that you've checked out my fork with the support-v5.18 branch? The code that fixes the compile issue isn't part of this repo.

@wolframd
Copy link

wolframd commented Jan 5, 2023

Oh, I think I was a bit blind and didn't realize you committed a patch. Great! Will try tomorrow and be back than. Thanks!

@wolframd
Copy link

Sorry, I was too busy the last weeks.
I went back to kernel 5.15. SMP PREEMPT. So far many things work well - but ;-)
SPDIF (both optical and coaxial) only transmits one channel. May it be the reason is alsamixer sending all channels as mono only?
Analog is noisy, every change on my display generates some noise (AMD Radeon HD Baffin).

@jimfrench
Copy link

jimfrench commented Apr 5, 2023

Confirmed working on
6.2.9-060209-generic #202303301133 SMP PREEMPT_DYNAMIC

Aside from index out of bounds error in hdspe_mixer.c (that was there before, doesn't seems to be stopping the mixer util from working, or the card)

Card is HDSPe AES

Analogue noise / interference, doesn;t sound like a driver issue to me? Maybe try card in different machine

snd_hdspe_log.txt

@fploetzlich
Copy link

Why did you not merge it?

@Schroedingers-Cat
Copy link
Author

Why did you not merge it?

Because of #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants