Skip to content

Commit

Permalink
update
Browse files Browse the repository at this point in the history
  • Loading branch information
PharmCat committed Feb 21, 2021
1 parent 876569b commit 7cbf9ff
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions src/MetidaNLopt.jl
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,9 @@ module MetidaNLopt
else
error("Unknown solver!")
end
if verbose == :auto
verbose = 1
end
############################################################################
#Initial variance
θ = zeros(T, lmm.covstr.tl)
Expand All @@ -71,9 +74,9 @@ module MetidaNLopt
############################################################################
#COBYLA
opt = NLopt.Opt(:LN_BOBYQA, thetalength(lmm))
#NLopt.ftol_rel!(opt, f_tol)
NLopt.ftol_rel!(opt, 0.0)
NLopt.ftol_abs!(opt, f_tol)
#NLopt.xtol_rel!(opt, 1.0e-14)
NLopt.xtol_rel!(opt, 0.0)
NLopt.xtol_abs!(opt, x_tol)
#opt.lower_bounds = lb::Union{AbstractVector,Real}
#opt.upper_bounds = ub::Union{AbstractVector,Real}
Expand Down Expand Up @@ -155,7 +158,7 @@ module MetidaNLopt
#θ₁ += sum(log.(diag(A[i])))*2
catch
lmmlog!(lmm, LMMLogMsg(:ERROR, "θ₁ not estimated during REML calculation, V isn't positive definite or |V| less zero."))
return (Inf, nothing, nothing, Inf)
return (1e100, nothing, nothing, 1e100)
end
vX = LinearAlgebra.LAPACK.potrs!('L', A[i], copy(data.xv[i]))
vy = LinearAlgebra.LAPACK.potrs!('L', A[i], copy(data.yv[i]))
Expand Down

2 comments on commit 7cbf9ff

@PharmCat
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/30564

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.2.0 -m "<description of version>" 7cbf9ffd504e99e5a3a16f3384a833ac11294fdb
git push origin v0.2.0

Please sign in to comment.