create HeadingComponent #11
Merged
+51
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TeamBattino
requested changes
Dec 9, 2024
silvio2402
requested changes
Dec 16, 2024
components/HeadingComponent.tsx
Outdated
There was a problem hiding this comment.
Please format the file. Tip: turn on format on save
components/HeadingComponent.tsx
Outdated
|
|
||
| function HeadingComponent({text, textAlign}: HeadingComponentProps){ | ||
| return ( | ||
| <div style={{padding: 64}}> |
There was a problem hiding this comment.
Is this padding needed, or is there a way to use the margin and min-height on the h1 tag?
components/HeadingComponent.tsx
Outdated
| textAlign: any, | ||
| }; | ||
|
|
||
| function HeadingComponent({text, textAlign}: HeadingComponentProps){ |
There was a problem hiding this comment.
Also, make sure the component is export default.
puck.config.tsx
Outdated
Comment on lines
33
to
35
| </div> | ||
| ), | ||
| }, |
There was a problem hiding this comment.
Since you created the component can you please also remove the HeadingBlock component here. It's no longer needed.
components/HeadingComponent.tsx
Outdated
There was a problem hiding this comment.
Let's also think about what this component does. How can you add different heading levels, like h1, h2 or h3?
I suggest we add a level prop to this component and make the user choose it.
# Conflicts: # puck.config.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #6