Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] [playground] add guided tour #934

Merged
merged 3 commits into from
Dec 15, 2023

Conversation

berkeli
Copy link
Contributor

@berkeli berkeli commented Dec 14, 2023

/claim #933

  • Implement the react-joyride package into Playground.. I have opted for https://ant.design/components/tour since we need to follow the same styling :)
  • Ensure correct highlighting of the related section in the steps.
  • Confirm compatibility with the current style and colors of the playground.
  • Verify the correctness of the content (text) provided in the issue description.

Video walkthrough:
https://www.loom.com/share/ed24d9edd57740f09260572a2e204b89?sid=d606132c-6269-4f2f-a482-afe13fc6316b

@@ -6,7 +6,7 @@ import Upload from "../services/s3";
import {nanoid} from "nanoid";
import yaml from "js-yaml";
import {useShapeStore} from "../state/shape";
import Share from "./components/modals/Share";
import Share from "./components/Modals/Share";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unrelated to my changes, but build was failing so had to fix it

@EgeAytin
Copy link
Member

EgeAytin commented Dec 15, 2023

It looks super cool @berkeli thanks for the great work and for the video to see the result 🙌 I'm merging this one.

Please type claim with using "/"

👉 To claim this bounty, submit a pull request that includes the text /claim #933 somewhere in its body

@EgeAytin EgeAytin merged commit 3956e89 into Permify:master Dec 15, 2023
4 of 5 checks passed
@EgeAytin EgeAytin added the area/playground Issues related with Permify Playground label Dec 15, 2023
@algora-pbc algora-pbc bot mentioned this pull request Dec 15, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/playground Issues related with Permify Playground 🙋 Bounty claim
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants