Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dumper.xs: use new SvVSTRING API #23165

Open
wants to merge 1 commit into
base: blead
Choose a base branch
from

Conversation

leonerd
Copy link
Contributor

@leonerd leonerd commented Mar 31, 2025

Use the new abstraction API rather than direct access to the MAGIC structures.

  • This set of changes does not require a perldelta entry.

Use the new abstraction API rather than direct access to the MAGIC
structures.
@leonerd
Copy link
Contributor Author

leonerd commented Mar 31, 2025

Oops, I broke the old perls. Shall have to investigate that...

@haarg
Copy link
Contributor

haarg commented Mar 31, 2025

I'm assuming this needs #23160

@Leont
Copy link
Contributor

Leont commented Apr 1, 2025

I'm assuming this needs #23160

Yeah, that's why I said earlier that moving version to dist/ wouldn't solve #23154 (though it would have triggered this sort of test failure, which is useful).

@jkeenan jkeenan added the dist-Data-Dumper issues in the dual-life blead-first Data-Dumper distribution label Apr 1, 2025
@jkeenan
Copy link
Contributor

jkeenan commented Apr 2, 2025

This p.r. has a dependency on another p.r. and must also pass on earlier versions of perl. Should we hold it until the 5.43 dev cycle?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dist-Data-Dumper issues in the dual-life blead-first Data-Dumper distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants