Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pp.c: pp_clonecv reorder TARGs init vs use, universal.c: remove a strlen #23162

Open
wants to merge 1 commit into
base: blead
Choose a base branch
from

Conversation

bulk88
Copy link
Contributor

@bulk88 bulk88 commented Mar 28, 2025

dTARGET macro, and macro ARGTARG both deref PL_op. find_runcv() is a fn. Reorder dTARGET to be after the find_runcv() call so the CC dedupes find the OP * with ARGTARG.

Remove 2 strlen() calls at proc start inside Perl_boot_core_UNIVERSAL().


  • This set of changes does not require a perldelta entry.

@tonycoz
Copy link
Contributor

tonycoz commented Mar 30, 2025

Are there words missing:

Reorder dTARGET to be after the find_runcv() call so the CC dedupes missing here?
find the OP * with ARGTARG.

dTARGET macro, and macro ARGTARG both deref PL_op. find_runcv() is a fn.
Reorder dTARGET to be after the find_runcv() call so the CC -O1 dedupes
reading inside the OP * between dTARGET/ARGTARG.

Remove 2 strlen() calls at proc start inside Perl_boot_core_UNIVERSAL().
@bulk88 bulk88 force-pushed the pp_clonecv_boot_universal_sml_cleanup branch from dbb7e8b to 57d3a7b Compare March 31, 2025 21:03
@bulk88
Copy link
Contributor Author

bulk88 commented Mar 31, 2025

Are there words missing:

Reorder dTARGET to be after the find_runcv() call so the CC dedupes missing here?
find the OP * with ARGTARG.

Yes there were missing words in description, repushed as version # 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants