Skip to content

Split PV typemap into mutable and immutable #23150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: blead
Choose a base branch
from
Draft

Split PV typemap into mutable and immutable #23150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions cpan/Compress-Raw-Zlib/Zlib.xs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2262,15 +2262,17 @@ getLastBufferOffset(s)
RETVAL

void
resetLastBlockByte(s, byte)
resetLastBlockByte(s, byte_sv)
Compress::Raw::Zlib::inflateScanStream s
unsigned char* byte
SV* byte_sv
CODE:
#ifndef MAGIC_APPEND
croak("resetLastBlockByte needs zlib 1.2.1 or better");
#else
if (byte != NULL)
if (SvOK(byte_sv)) {
unsigned char* byte = (unsigned char*)SvPV_force_nolen(byte_sv);
Comment on lines -2272 to +2273
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If byte_sv is magical this checks the flags before SvGETMAGIC().

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course, the original didn't force, and neither checks the length of byte_sv.

It's hard to tell what the intent is, the only test calls with undef and it isn't documented.

*byte = *byte ^ (1 << ((8 - s->window_lastbit) & 7));
}
#endif


Expand Down
2 changes: 1 addition & 1 deletion cpan/Compress-Raw-Zlib/lib/Compress/Raw/Zlib.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ use warnings ;
use bytes ;
our ($VERSION, $XS_VERSION, @ISA, @EXPORT, %EXPORT_TAGS, @EXPORT_OK, $AUTOLOAD, %DEFLATE_CONSTANTS, @DEFLATE_CONSTANTS);

$VERSION = '2.213';
$VERSION = '2.214';
$XS_VERSION = $VERSION;
$VERSION = eval $VERSION;

Expand Down
2 changes: 1 addition & 1 deletion cpan/DB_File/DB_File.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ use Carp;
# Module not thread safe, so don't clone
sub CLONE_SKIP { 1 }

$VERSION = "1.859" ;
$VERSION = "1.860" ;
$VERSION = eval $VERSION; # needed for dev releases

{
Expand Down
8 changes: 4 additions & 4 deletions cpan/DB_File/DB_File.xs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1578,10 +1578,10 @@ BOOT:

DB_File
db_DoTie_(isHASH, dbtype, name=undef, flags=O_CREAT|O_RDWR, mode=0666, type=DB_HASH)
int isHASH
char * dbtype
int flags
int mode
int isHASH
const char * dbtype
int flags
int mode
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe rmv white space only changes on unrelated lines? makes future git blames confusing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variables are aligned, I'm keeping that alignment here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved.

CODE:
{
char * name = (char *) NULL ;
Expand Down
2 changes: 1 addition & 1 deletion cpan/Socket/Socket.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ package Socket;
use v5.6.1;
use strict;

our $VERSION = '2.038';
our $VERSION = '2.039';

=head1 NAME

Expand Down
2 changes: 1 addition & 1 deletion cpan/Socket/Socket.xs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -776,7 +776,7 @@ BOOT:

void
inet_aton(host)
char * host
const char * host
CODE:
{
#ifdef HAS_GETADDRINFO
Expand Down
2 changes: 1 addition & 1 deletion ext/DynaLoader/DynaLoader_pm.PL
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ package DynaLoader;
# [email protected], August 1994

BEGIN {
our $VERSION = '1.57';
our $VERSION = '1.58';
}

# Note: in almost any other piece of code "our" would have been a better
Expand Down
6 changes: 3 additions & 3 deletions ext/DynaLoader/dl_aix.xs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -692,7 +692,7 @@ BOOT:

void
dl_load_file(filename, flags=0)
char * filename
const char * filename
int flags
PREINIT:
void *retv;
Expand Down Expand Up @@ -724,7 +724,7 @@ dl_unload_file(libref)
void
dl_find_symbol(libhandle, symbolname, ign_err=0)
void * libhandle
char * symbolname
const char * symbolname
int ign_err
PREINIT:
void *retv;
Expand All @@ -751,7 +751,7 @@ dl_undef_symbols()

void
dl_install_xsub(perl_name, symref, filename="$Package")
char * perl_name
const char * perl_name
void * symref
const char * filename
CODE:
Expand Down
6 changes: 3 additions & 3 deletions ext/DynaLoader/dl_dllload.xs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ BOOT:

void
dl_load_file(filename, flags=0)
char * filename
const char * filename
int flags
PREINIT:
int mode = 0;
Expand Down Expand Up @@ -144,7 +144,7 @@ dl_unload_file(libref)
void
dl_find_symbol(libhandle, symbolname, ign_err=0)
void * libhandle
char * symbolname
const char * symbolname
int ign_err
PREINIT:
void *retv;
Expand Down Expand Up @@ -175,7 +175,7 @@ dl_undef_symbols()

void
dl_install_xsub(perl_name, symref, filename="$Package")
char * perl_name
const char * perl_name
void * symref
const char * filename
PPCODE:
Expand Down
6 changes: 3 additions & 3 deletions ext/DynaLoader/dl_dlopen.xs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ BOOT:

SV *
dl_load_file(filename, flags=0)
char * filename
const char * filename
int flags
PREINIT:
int mode = RTLD_LAZY;
Expand Down Expand Up @@ -234,7 +234,7 @@ dl_unload_file(libref)
SV *
dl_find_symbol(libhandle, symbolname, ign_err=0)
void * libhandle
char * symbolname
const char * symbolname
int ign_err
PREINIT:
void *sym;
Expand Down Expand Up @@ -269,7 +269,7 @@ dl_undef_symbols()

SV *
dl_install_xsub(perl_name, symref, filename="$Package")
char * perl_name
const char * perl_name
void * symref
const char * filename
CODE:
Expand Down
6 changes: 3 additions & 3 deletions ext/DynaLoader/dl_dyld.xs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ BOOT:

void *
dl_load_file(filename, flags=0)
char * filename
const char * filename
int flags
CODE:
DLDEBUG(1,PerlIO_printf(Perl_debug_log, "dl_load_file(%s,%x):\n", filename,flags));
Expand All @@ -174,7 +174,7 @@ dl_load_file(filename, flags=0)
void *
dl_find_symbol(libhandle, symbolname, ign_err=0)
void * libhandle
char * symbolname
const char * symbolname
int ign_err
CODE:
symbolname = Perl_form_nocontext("_%s", symbolname);
Expand Down Expand Up @@ -202,7 +202,7 @@ dl_undef_symbols()

void
dl_install_xsub(perl_name, symref, filename="$Package")
char * perl_name
const char * perl_name
void * symref
const char * filename
CODE:
Expand Down
6 changes: 3 additions & 3 deletions ext/DynaLoader/dl_freemint.xs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ BOOT:

void
dl_load_file(filename, flags=0)
char * filename
const char * filename
int flags
PREINIT:
int dlderr,x,max;
Expand Down Expand Up @@ -147,7 +147,7 @@ haverror:
void
dl_find_symbol(libhandle, symbolname, ign_err=0)
void * libhandle
char * symbolname
const char * symbolname
int ign_err
PREINIT:
void *retv;
Expand Down Expand Up @@ -183,7 +183,7 @@ dl_undef_symbols()

void
dl_install_xsub(perl_name, symref, filename="$Package")
char * perl_name
const char * perl_name
void * symref
const char * filename
CODE:
Expand Down
6 changes: 3 additions & 3 deletions ext/DynaLoader/dl_hpux.xs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ BOOT:

void
dl_load_file(filename, flags=0)
char * filename
const char * filename
int flags
PREINIT:
shl_t obj = NULL;
Expand Down Expand Up @@ -120,7 +120,7 @@ dl_unload_file(libref)
void
dl_find_symbol(libhandle, symbolname, ign_err=0)
void * libhandle
char * symbolname
const char * symbolname
int ign_err
PREINIT:
shl_t obj = (shl_t) libhandle;
Expand Down Expand Up @@ -162,7 +162,7 @@ dl_undef_symbols()

void
dl_install_xsub(perl_name, symref, filename="$Package")
char * perl_name
const char * perl_name
void * symref
const char * filename
CODE:
Expand Down
6 changes: 3 additions & 3 deletions ext/DynaLoader/dl_vms.xs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ BOOT:

SV *
dl_expandspec(filespec)
char * filespec
const char * filespec
CODE:
char vmsspec[NAM$C_MAXRSS], defspec[NAM$C_MAXRSS];
size_t deflen;
Expand Down Expand Up @@ -222,7 +222,7 @@ dl_expandspec(filespec)

SV *
dl_load_file(filename, flags=0)
char * filename
const char * filename
int flags
PREINIT:
dTHX;
Expand Down Expand Up @@ -345,7 +345,7 @@ dl_undef_symbols()

SV *
dl_install_xsub(perl_name, symref, filename="$Package")
char * perl_name
const char * perl_name
void * symref
const char * filename
CODE:
Expand Down
6 changes: 3 additions & 3 deletions ext/DynaLoader/dl_win32.xs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ BOOT:

void
dl_load_file(filename,flags=0)
char * filename
const char * filename
#flags is unused
SV * flags = NO_INIT
PREINIT:
Expand Down Expand Up @@ -160,7 +160,7 @@ dl_unload_file(libref)
void
dl_find_symbol(libhandle, symbolname, ign_err=0)
void * libhandle
char * symbolname
const char * symbolname
int ign_err
PREINIT:
void *retv;
Expand All @@ -186,7 +186,7 @@ dl_undef_symbols()

void
dl_install_xsub(perl_name, symref, filename="$Package")
char * perl_name
const char * perl_name
void * symref
const char * filename
CODE:
Expand Down
2 changes: 1 addition & 1 deletion ext/GDBM_File/GDBM_File.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -733,7 +733,7 @@ require XSLoader;
);

# This module isn't dual life, so no need for dev version numbers.
$VERSION = '1.24';
$VERSION = '1.25';

our $gdbm_errno;

Expand Down
16 changes: 8 additions & 8 deletions ext/GDBM_File/GDBM_File.xs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,8 +312,8 @@ gdbm_GDBM_version(package)

GDBM_File
gdbm_TIEHASH(dbtype, name, read_write, mode)
char * dbtype
char * name
const char * dbtype
const char * name
int read_write
int mode
PREINIT:
Expand Down Expand Up @@ -684,7 +684,7 @@ gdbm_count(db)
void
gdbm_dump(db, filename, ...)
GDBM_File db
char * filename
const char * filename
PREINIT:
int format = GDBM_DUMP_FMT_ASCII;
int flags = GDBM_WRCREAT;
Expand Down Expand Up @@ -725,7 +725,7 @@ gdbm_dump(db, filename, ...)
void
gdbm_load(db, filename, ...)
GDBM_File db
char * filename
const char * filename
PREINIT:
int flag = GDBM_INSERT;
int meta_mask = 0;
Expand Down Expand Up @@ -1012,8 +1012,8 @@ gdbm_convert(db, flag)
int
gdbm_failure_atomic(db, even, odd)
GDBM_File db
char * even
char * odd
const char * even
const char * odd
INIT:
CHECKDB(db);
CLEANUP:
Expand All @@ -1023,8 +1023,8 @@ gdbm_failure_atomic(db, even, odd)

void
gdbm_latest_snapshot(package, even, odd)
char * even
char * odd
const char * even
const char * odd
INIT:
int result;
int syserr;
Expand Down
2 changes: 1 addition & 1 deletion ext/NDBM_File/NDBM_File.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ require Tie::Hash;
require XSLoader;

our @ISA = qw(Tie::Hash);
our $VERSION = "1.18";
our $VERSION = "1.19";

XSLoader::load();

Expand Down
6 changes: 3 additions & 3 deletions ext/NDBM_File/NDBM_File.xs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,16 +60,16 @@ MODULE = NDBM_File PACKAGE = NDBM_File PREFIX = ndbm_

NDBM_File
ndbm_TIEHASH(dbtype, filename, flags, mode)
char * dbtype
char * filename
const char * dbtype
const char * filename
int flags
int mode
CODE:
{
DBM * dbp ;

RETVAL = NULL ;
if ((dbp = dbm_open(filename, flags, mode))) {
if ((dbp = dbm_open((char*)filename, flags, mode))) {
RETVAL = (NDBM_File)safecalloc(1, sizeof(NDBM_File_type));
RETVAL->dbp = dbp ;
}
Expand Down
2 changes: 1 addition & 1 deletion ext/ODBM_File/ODBM_File.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ require Tie::Hash;
require XSLoader;

our @ISA = qw(Tie::Hash);
our $VERSION = "1.20";
our $VERSION = "1.21";

XSLoader::load();

Expand Down
Loading
Loading