Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build images for bookworm, as well as buster. #62

Merged
merged 1 commit into from
May 5, 2024
Merged

Conversation

rspier
Copy link
Contributor

@rspier rspier commented May 5, 2024

Build images for bookworm, as well as buster. Extend the matrix configuration to cover the base image and appropriate tags changes. Existing unlabeled tags (e.g. 5.36) remain buster.

Buster is oldoldstable at this point, and is getting long in the tooth. For example, it has an old version of git that does not support all the flags we'd like to use in the PAUSE tests.

@rspier
Copy link
Contributor Author

rspier commented May 5, 2024

In issue #32 , @oalders expressed concerns about rate limiting on dockerhub. I don't think they have any upload rate limiting. (And I couldn't find any documentation of such.) They do have download rate limiting. It might be worth considering also pushing to GitHub Container Registry.

This PR also obsoletes or enables (depending on your point of view) issue #32. It would be trivial to also build bullseye now, if that was still wanted.

@rspier
Copy link
Contributor Author

rspier commented May 5, 2024

Check failure is pre-existing.

@oalders
Copy link
Collaborator

oalders commented May 5, 2024

Thanks, @rspier!

@oalders oalders merged commit 13724ed into Perl:main May 5, 2024
17 of 18 checks passed
@rspier
Copy link
Contributor Author

rspier commented May 5, 2024

I didn't notice that bookworm images only exist for 5.36 and later.

But it worked: https://hub.docker.com/layers/perldocker/perl-tester/5.36-bookworm/images/sha256-f1fc120b622637ab2ea8a1abaee7fc89e2e383e4b127367223dce9191b81342a?context=explore

This means a lot of builds are failing.

Followup PR coming.

rspier added a commit to rspier/docker-perl-tester that referenced this pull request May 5, 2024
Fix the failing image builds created in Perl#62 by splitting bookworm into its
own build step with a different set of version inputs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants