-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use perl-actions/perl-versions to build perl-versions matrix #57
Conversation
Delay can be mitigated by triggering
Same can be used by other repositories, eg |
- '5.12' | ||
- '5.10' | ||
- '5.8' | ||
perl-version: ${{ fromJson (needs.prepare-matrix.outputs.perl-versions) }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do the outputs include devel
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's controlled by argument with-devel
(set to 'true`)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... there was missing needs
parameter of jobs
(therefor resulted into empty string)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is super cool!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not clear what s the output of the list when using with-level: true
is the string devel
going to be added there or would a development version be added? like 5.39.1
?
from the doc:
When set to true, returned list will also include current devel version of Perl, if available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it will include devel
41d5a72
to
4f72963
Compare
to maintain single list of available perl versions Advantage - new versions will automatically spread Disadvantage: - there will be some delay between committing new version and new docker image available.
4f72963
to
aafd636
Compare
- '5.12' | ||
- '5.10' | ||
- '5.8' | ||
perl-version: ${{ fromJson (needs.prepare-matrix.outputs.perl-versions) }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is super cool!
- '5.12' | ||
- '5.10' | ||
- '5.8' | ||
perl-version: ${{ fromJson (needs.prepare-matrix.outputs.perl-versions) }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not clear what s the output of the list when using with-level: true
is the string devel
going to be added there or would a development version be added? like 5.39.1
?
from the doc:
When set to true, returned list will also include current devel version of Perl, if available.
to maintain single list of available perl versions
Advantage
Disadvantage: