Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use perl-actions/perl-versions to build perl-versions matrix #57

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

happy-barney
Copy link
Contributor

to maintain single list of available perl versions

Advantage

  • new versions will automatically spread

Disadvantage:

  • there will be some delay between committing new version and new docker image available

@happy-barney
Copy link
Contributor Author

Delay can be mitigated by triggering publish-to-docker workflow from perl-actions/perl-versions by adding
workflow on pull request merge

on:
  pull_request:
    types:
      - closed

jobs:
  if_merged:
    if: github.event.pull_request.merged == true

Same can be used by other repositories, eg ci-perl-test-helpers

- '5.12'
- '5.10'
- '5.8'
perl-version: ${{ fromJson (needs.prepare-matrix.outputs.perl-versions) }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the outputs include devel?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's controlled by argument with-devel (set to 'true`)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... there was missing needs parameter of jobs (therefor resulted into empty string)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is super cool!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not clear what s the output of the list when using with-level: true
is the string devel going to be added there or would a development version be added? like 5.39.1?
from the doc:

When set to true, returned list will also include current devel version of Perl, if available.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will include devel

to maintain single list of available perl versions

Advantage
- new versions will automatically spread

Disadvantage:
- there will be some delay between committing new version
  and new docker image available.
- '5.12'
- '5.10'
- '5.8'
perl-version: ${{ fromJson (needs.prepare-matrix.outputs.perl-versions) }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is super cool!

- '5.12'
- '5.10'
- '5.8'
perl-version: ${{ fromJson (needs.prepare-matrix.outputs.perl-versions) }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not clear what s the output of the list when using with-level: true
is the string devel going to be added there or would a development version be added? like 5.39.1?
from the doc:

When set to true, returned list will also include current devel version of Perl, if available.

@atoomic atoomic merged commit 8d555e2 into Perl:main Nov 7, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants