Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more dzil plugins #53

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Add more dzil plugins #53

merged 1 commit into from
Sep 19, 2023

Conversation

oalders
Copy link
Collaborator

@oalders oalders commented Sep 19, 2023

No description provided.

atoomic
atoomic requested changes Sep 19, 2023
View reviewed changes
Copy link
Member

@atoomic atoomic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note the failure from pipeline

@atoomic
Copy link
Member

atoomic commented Sep 19, 2023

Probably need to rerun ci after recent merge

@atoomic
Copy link
Member

atoomic commented Sep 19, 2023

Please rebase and resubmit

@atoomic
Copy link
Member

atoomic commented Sep 19, 2023

let s wait for the smoker result :-)

atoomic
atoomic approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@atoomic atoomic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should be good we are inside a >= 5.20 block :-)

@atoomic atoomic merged commit 19a760a into main Sep 19, 2023
18 checks passed
@oalders oalders deleted the oalders/more-deps branch September 20, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atoomic atoomic atoomic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oalders @atoomic