Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix up PPI::Token::insert_{after,before}. #79

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix up PPI::Token::insert_{after,before}. #79

wants to merge 1 commit into from

Commits on Mar 29, 2014

  1. Fix up PPI::Token::insert_{after,before}. 

    I stumbled across this while trying to make
Dist::Zilla::Plugin::PkgVersion work better with perlcritic.  More
info here:

   rjbs/Dist-Zilla#168

The comments for PPI::Token::insert_{after,before} say that they may
only insert statements, but the code inexplicably requires
PPI::Structures.

I think that requiring a Statement is appropriate the right thing,
this commit makes the code match the comment.

The tests in t still pass.

I'll submit a pull request and hope for feedback from folks wise.
    @hartzell
    hartzell committed Mar 29, 2014
    Configuration menu
    Copy the full SHA
    bf2ae02 View commit details
    Browse the repository at this point in the history