Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

have the dependents test test all dependents #292

Closed
wants to merge 0 commits into from

Conversation

wchristian
Copy link
Member

Fixed this up to run relatively fast (about 12 minutes). Two issues that remain:

  • the "install extra modules" step could probably be cached? @haarg, olaf mentioned you as someone who might know how?
  • the failing test themselves aren't output. gonna need to debug that and see how the test module can be made to do that, because the docs don't say

@wchristian wchristian force-pushed the all-dependents-test branch 2 times, most recently from 27d3c09 to 9cd26f0 Compare September 24, 2023 15:30
@wchristian
Copy link
Member Author

Ran the action against the previous version, and there only Devel::Examine::Subs failed, which might have more to do with the environment than PPI changing. Otherwise only Perl::Critic fails, which has a PR fix from me.

@oalders
Copy link
Collaborator

oalders commented Mar 9, 2024

@wchristian just wondering why you closed this?

@wchristian
Copy link
Member Author

@oalders correcting my previous statement: the pull request was closed because the code in question is done and merged, however the bigger issue is still in question in #297

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants