Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update users and active-users against anonymous ldap authentication #441

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Update users and active-users against anonymous ldap authentication #441

wants to merge 5 commits into from

Conversation

termanix
Copy link
Contributor

@termanix termanix commented Oct 9, 2024

This PR includes update and bug fix against anonym ldap auhtentication.

Before Update:

image

After Update:

image

@NeffIsBack NeffIsBack added bug-fix This Pull Request fixes a bug enhancement New feature or request labels Oct 10, 2024
NeffIsBack
NeffIsBack requested changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@NeffIsBack NeffIsBack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As always, thanks for your work! :)

A few code improvements and we should be good to go

nxc/protocols/ldap.py Outdated Show resolved Hide resolved
nxc/protocols/ldap.py Outdated Show resolved Hide resolved
nxc/protocols/ldap.py Outdated Show resolved Hide resolved
nxc/protocols/ldap.py Outdated Show resolved Hide resolved
nxc/protocols/ldap.py Outdated Show resolved Hide resolved
nxc/protocols/ldap.py Outdated Show resolved Hide resolved
@termanix
Copy link
Contributor Author

As always, thanks for your work! :)

A few code improvements and we should be good to go

Thanks for your improvement feedbacks ^^

I will commit for ldap_results too but we need to look at it later.
The merging of this PR will happen after many testing phases.

@termanix
Copy link
Contributor Author

"update ldap_results for now" commit for this PR. It will take some time for merging.

@termanix termanix mentioned this pull request Oct 21, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeffIsBack NeffIsBack NeffIsBack requested changes

@zblurx zblurx Awaiting requested review from zblurx zblurx is a code owner

@Marshall-Hallenbeck Marshall-Hallenbeck Awaiting requested review from Marshall-Hallenbeck Marshall-Hallenbeck is a code owner

@mpgn mpgn Awaiting requested review from mpgn mpgn is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
bug-fix This Pull Request fixes a bug enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@termanix @NeffIsBack