Mssql xp_cmdshell added "is enabled" check #405
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Pull request
about: Update code to add an enhancement
title: Add functionality to check if xp_cmdshell is enabled before execution
labels: enhancement
Description
This update adds functionality to check if
xp_cmdshell
is enabled before attempting to enable it. This enhancement prevents unnecessary changes to the state ofxp_cmdshell
. The updated code now:xp_cmdshell
is enabled usingsp_configure
.xp_cmdshell
is already enabled, without altering its state.xp_cmdshell
only if it is disabled, executes the command, and then restores the original state by disabling it again.Motivation: This change ensures that
xp_cmdshell
is not disabled after the execution if it was enabled initially, maintaining the target system's configuration integrity.Dependencies: No new dependencies were introduced in this change.
Type of change
How Has This Been Tested?
xp_cmdshell
already enabled: Verified that the command executes without disablingxp_cmdshell
.xp_cmdshell
disabled: Verified that the command enablesxp_cmdshell
, executes successfully, and restores the disabled state afterward.Test Configuration:
Screenshots:
xp_cmdshell
disabled flow:xp_cmdshell
enabled flow: