Skip to content

Commit

Permalink
Remove exposition-only types from group interface
Browse files Browse the repository at this point in the history
  • Loading branch information
Pennycook committed Dec 10, 2024
1 parent a1a7e8c commit dd2110a
Showing 1 changed file with 7 additions and 9 deletions.
16 changes: 7 additions & 9 deletions adoc/extensions/sycl_khr_group_interface.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,6 @@ class __group__ {
using range_type = /* ... */;
#if defined(__cpp_lib_mdspan)
using extents_type = /* ... */;
using index_type = typename extents_type::index_type; // exposition only
using rank_type = typename extents_type::rank_type; // exposition only
#endif
using size_type = /* ... */;
static constexpr int dimensions = /* ... */;
Expand All @@ -69,10 +67,10 @@ class __group__ {
#if defined (__cpp_lib_mdspan)
constexpr extents_type extents() const noexcept;
constexpr index_type extent(rank_type r) const noexcept;
constexpr extents_type::index_type extent(extents_type::rank_type r) const noexcept;
static constexpr rank_type rank() noexcept;
static constexpr rank_type rank_dynamic() noexcept;
static constexpr extents_type::rank_type rank() noexcept;
static constexpr extents_type::rank_type rank_dynamic() noexcept;
static constexpr size_t static_extent(rank_type r) noexcept;
#endif
constexpr size_type size() const noexcept;
Expand Down Expand Up @@ -139,7 +137,7 @@ _Returns_: The number of work-items in each dimension of the group.
.[apidef]#__group__::extent#
[source,role=synopsis,id=api:khr-group-interface-common-group-extent]
----
constexpr index_type extent(rank_type r) const noexcept;
constexpr extents_type::index_type extent(extents_type::rank_type r) const noexcept;
----

_Preconditions_: [code]#r < dimensions# is [code]#true#.
Expand All @@ -151,7 +149,7 @@ _Returns_: The number of work-items in the specified dimension of the group.
.[apidef]#__group__::rank#
[source,role=synopsis,id=api:khr-group-interface-common-group-rank]
----
static constexpr rank_type rank() noexcept;
static constexpr extents_type::rank_type rank() noexcept;
----

_Effects_: Equivalent to [code]#return extents_type::rank();#.
Expand All @@ -161,7 +159,7 @@ _Effects_: Equivalent to [code]#return extents_type::rank();#.
.[apidef]#__group__::rank_dynamic#
[source,role=synopsis,id=api:khr-group-interface-common-group-rank_dynamic]
----
static constexpr rank_type rank_dynamic() noexcept;
static constexpr extents_type::rank_type rank_dynamic() noexcept;
----

_Effects_: Equivalent to [code]#return extents_type::rank_dynamic();#.
Expand All @@ -171,7 +169,7 @@ _Effects_: Equivalent to [code]#return extents_type::rank_dynamic();#.
.[apidef]#__group__::static_extent#
[source,role=synopsis,id=api:khr-group-interface-common-group-static_extent]
----
static constexpr size_t static_extent(rank_type r) noexcept;
static constexpr size_t static_extent(extents_type::rank_type r) noexcept;
----

_Effects_: Equivalent to [code]#return extents_type::static_extent(r);#.
Expand Down

0 comments on commit dd2110a

Please sign in to comment.