Skip to content

Commit

Permalink
Updated all instances of upload/download artifact to use v4 (#1295)
Browse files Browse the repository at this point in the history
**Title:** Updated all instances of upload/download artifact to use v4

**Summary:**
All versions of `actions/upload-artifact` and
`actions/download-artifact` that are older than major version `v4` are
no longer supported by GitHub: [See
Blogpost](https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/)

This PR updates all instances of these actions within the QML CI to use
the v4 version.

**Relevant references:**
[sc-81821]

**Possible Drawbacks:**
Though on the slight chance some hiccups can be encountered, we have no
choice but for fall forwards on this change.

**Related GitHub Issues:**
None.
  • Loading branch information
rashidnhm authored Jan 9, 2025
1 parent f2e3e11 commit d135e0c
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 16 deletions.
16 changes: 8 additions & 8 deletions .github/workflows/build-branch.yml
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ jobs:
echo "strategy-matrix=$matrix" >> $GITHUB_OUTPUT
- name: Upload Workers Load Data as Artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: ${{ steps.compute-strategy-matrix.outputs.worker_load_artifact_name }}
path: ${{ steps.compute-strategy-matrix.outputs.worker_load_file_name }}
Expand Down Expand Up @@ -323,7 +323,7 @@ jobs:
sudo apt install ocl-icd-opencl-dev
- name: Download Worker Load Data Artifact
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: ${{ needs.compute-build-strategy-matrix.outputs.worker-load-artifact-name }}

Expand Down Expand Up @@ -466,7 +466,7 @@ jobs:
- name: Upload Execution Times
if: inputs.skip_execution_of_examples == false
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: execution_times_${{ matrix.offset }}.zip
if-no-files-found: error
Expand Down Expand Up @@ -500,7 +500,7 @@ jobs:
- name: Upload Html
if: matrix.offset == 0
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: html-${{ matrix.offset }}.zip
if-no-files-found: error
Expand All @@ -513,7 +513,7 @@ jobs:
# The step above this is executed by only one worker which uploads all static content.
- name: Upload Demo Html
if: matrix.offset != 0
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: html-${{ matrix.offset }}.zip
if-no-files-found: error
Expand All @@ -534,7 +534,7 @@ jobs:
- build-branch
steps:
- name: Download Artifacts
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
path: artifacts

Expand Down Expand Up @@ -564,15 +564,15 @@ jobs:
- name: Upload Sphinx Build files
if: inputs.skip_sphinx_build_file_aggregation == false
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: ${{ inputs.sphinx_build_output_format }}.zip
if-no-files-found: error
path: artifacts/website

- name: Upload Execution Times
if: inputs.skip_execution_of_examples == false && inputs.skip_execution_times_aggregation == false
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: execution_times.zip
path: /tmp/execution_times
2 changes: 1 addition & 1 deletion .github/workflows/build-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ jobs:
EOL
- name: Upload Pull Request Event Context as Artifact
if: github.event_name == 'pull_request'
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: pr_info
path: /tmp/pr
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/demo_diff_check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ jobs:
make html
zip -r /tmp/qml_demos.zip demos
- uses: actions/upload-artifact@v2
- uses: actions/upload-artifact@v4
with:
name: built-website-dev
path: |
Expand Down Expand Up @@ -136,7 +136,7 @@ jobs:
make html
zip -r /tmp/qml_demos.zip demos
- uses: actions/upload-artifact@v2
- uses: actions/upload-artifact@v4
with:
name: built-website-master
path: |
Expand All @@ -156,15 +156,15 @@ jobs:
- name: Create dev dir
run: mkdir /tmp/dev/

- uses: actions/download-artifact@v2
- uses: actions/download-artifact@v4
with:
name: built-website-dev
path: /tmp/dev/

- name: Create master dir
run: mkdir /tmp/master/

- uses: actions/download-artifact@v2
- uses: actions/download-artifact@v4
with:
name: built-website-master
path: /tmp/master/
Expand All @@ -186,7 +186,7 @@ jobs:
git commit -m "Update the demonstration differences found"
git push
- uses: actions/upload-artifact@v2
- uses: actions/upload-artifact@v4
with:
name: demo_diffs
path: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/upload-json.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ jobs:

- name: Download HTML
id: qml_json
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: ${{ inputs.artifact_name }}
path: qml_json
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/upload-text.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:

- name: Download Text
id: qml_text
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: ${{ inputs.artifact_name }}
path: qml_text
Expand Down

0 comments on commit d135e0c

Please sign in to comment.