Ensure Lightning is tested as RC/RC #78
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[sc-62303] |
| | | Latest plugin/ release candidate PennyLane | | ||
| | | Release candidate plugin / Release candidate PennyLane | | ||
| | :-------------------------------------------------------------------------- | :------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | ||
| | [Lightning](https://github.com/PennyLaneAI/pennylane-lightning) | [](https://github.com/PennyLaneAI/plugin-test-matrix/actions/workflows/lightning-rc-rc.yml) | |
There was a problem hiding this comment.
We can use the script we already have in the repository for that.
I am shamelessly stealing it from @vincentmr's branch.
Suggested change
| | [Lightning](https://github.com/PennyLaneAI/pennylane-lightning) | [](https://github.com/PennyLaneAI/plugin-test-matrix/actions/workflows/lightning-rc-rc.yml) | | |
| | [](https://github.com/PennyLaneAI/pennylane-lightning/actions/workflows/compat-check-release-release.yml) | |
There was a problem hiding this comment.
Thanks @AmintorDusko . Yes, we already have a kron job which also tests L-GPU (+MPI) and L-Kokkos (CUDA), so I think this is preferable.
There was a problem hiding this comment.
If you agree @mlxd , I'll just open a PR trying to merge my branch.
There was a problem hiding this comment.
Whatever solution helps resolve this, I'm in favour of. But let's get it in before end of day if possible. If it'll take longer, let's go ahead with this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Lightning is currently tested as RC PennyLane/Latest Lightning, which can diverge from the release-candidate for Lightning. This PR updates the RC table to have RC/RC and RC/latest categories.