Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concatenate across directions as well as runs #965

Merged
merged 6 commits into from
Oct 10, 2023

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Oct 10, 2023

Closes none. This will primarily (only?) affect HCP data, which acquires fMRI runs with both run entities and dir entities. The acquisition order is counterbalanced, so we can't ensure that the data will be concatenated in the right order, but it should still be an improvement.

Changes proposed in this pull request

  • Concatenate BOLD data across run and dir entities.
  • Sort the files first by run, then by direction.
    • This is because HCP acquires run 1 in session 1 and run 2 in session 2. The order of directions (LR and RL) is counterbalanced, but run is consistent. Therefore we can't guarantee that LR --> RL is right (it'll be right for one run, but not the other), but we can guarantee that run 1 --> run 2.

@tsalo tsalo added the enhancement New feature or request label Oct 10, 2023
@tsalo tsalo added this to the manuscript milestone Oct 10, 2023
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
xcp_d/utils/bids.py 86.88% <100.00%> (+0.26%) ⬆️
xcp_d/workflows/base.py 97.12% <100.00%> (ø)
xcp_d/workflows/concatenation.py 87.23% <ø> (ø)

📢 Thoughts on this report? Let us know!.

@tsalo tsalo merged commit ac5a1b0 into PennLINC:main Oct 10, 2023
4 checks passed
@tsalo tsalo deleted the concatenate-dir branch October 10, 2023 18:05
tsalo added a commit to tsalo/xcp_d that referenced this pull request Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant