Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow sub- prefix in participant labels #1347

Merged
merged 2 commits into from
Jan 2, 2025
Merged

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Jan 2, 2025

Closes #1341.

Changes proposed in this pull request

  • Automatically drop the sub- prefix, when present, in participant label inputs. This will allow users to specify participant labels with or without the sub- prefix.

@tsalo tsalo added bug Issues noting problems and PRs fixing those problems. nipreps Issues/PRs related to keeping XCP-D in line with the NiPreps ecosystem. labels Jan 2, 2025
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.00%. Comparing base (3f7b6fa) to head (8963455).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1347      +/-   ##
==========================================
+ Coverage   78.96%   79.00%   +0.04%     
==========================================
  Files          59       59              
  Lines        7406     7406              
  Branches      962      962              
==========================================
+ Hits         5848     5851       +3     
+ Misses       1268     1267       -1     
+ Partials      290      288       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo tsalo merged commit 43c649a into PennLINC:main Jan 2, 2025
24 checks passed
@tsalo tsalo deleted the accept-sub branch January 2, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues noting problems and PRs fixing those problems. nipreps Issues/PRs related to keeping XCP-D in line with the NiPreps ecosystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow sub-<label>-format participant IDs
1 participant