Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nichart mode #1320

Merged
merged 7 commits into from
Nov 17, 2024
Merged

Add nichart mode #1320

merged 7 commits into from
Nov 17, 2024

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Nov 5, 2024

Closes none.

Changes proposed in this pull request

  • Add a "nichart" mode that matches how the NiChart project is processing its data.
  • Make the default values for --smoothing and --min-coverage "auto", since "nichart" mode has defaults that differ from the current defaults.

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.04%. Comparing base (7694faa) to head (cfa1385).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1320      +/-   ##
==========================================
+ Coverage   78.96%   79.04%   +0.08%     
==========================================
  Files          59       59              
  Lines        7383     7412      +29     
  Branches      957      961       +4     
==========================================
+ Hits         5830     5859      +29     
  Misses       1261     1261              
  Partials      292      292              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo tsalo added the enhancement New feature or request label Nov 14, 2024
@tsalo tsalo merged commit 7fe1a55 into PennLINC:main Nov 17, 2024
24 checks passed
@tsalo tsalo deleted the nicharts-mode branch November 17, 2024 14:53
@tsalo tsalo mentioned this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant