Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track lost degrees of freedom #1307

Merged
merged 16 commits into from
Jan 23, 2025
Merged

Track lost degrees of freedom #1307

merged 16 commits into from
Jan 23, 2025

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Oct 29, 2024

Closes #1296.

Changes proposed in this pull request

  • Calculate lost degrees of freedom in LINC QC file.
  • Fix up some of the documentation.

@tsalo tsalo added the enhancement New feature or request label Oct 29, 2024
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 43.33333% with 17 lines in your changes missing coverage. Please review.

Project coverage is 78.66%. Comparing base (14440d5) to head (452ab54).
Report is 17 commits behind head on dof.

Files with missing lines Patch % Lines
xcp_d/utils/modified_data.py 42.10% 11 Missing ⚠️
xcp_d/interfaces/utils.py 45.45% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dof    #1307      +/-   ##
==========================================
- Coverage   78.81%   78.66%   -0.15%     
==========================================
  Files          58       58              
  Lines        7223     7243      +20     
  Branches      951      952       +1     
==========================================
+ Hits         5693     5698       +5     
- Misses       1251     1266      +15     
  Partials      279      279              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo
Copy link
Member Author

tsalo commented Oct 30, 2024

Track remaining degrees of freedom (ignoring dfs from statistical tests)

@tsalo tsalo changed the base branch from main to dof January 23, 2025 14:15
@tsalo tsalo merged commit 9a17e1d into PennLINC:dof Jan 23, 2025
20 of 22 checks passed
@tsalo tsalo deleted the dof branch January 23, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Track lost degrees of freedom
1 participant