Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with surfaces and external atlases #1304

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Oct 24, 2024

Closes #1303.

Changes proposed in this pull request

  • Don't raise an error in select_atlases if external atlases are provided.

@tsalo tsalo added the bug Issues noting problems and PRs fixing those problems. label Oct 24, 2024
@tsalo tsalo merged commit e842748 into PennLINC:main Oct 24, 2024
21 checks passed
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.89%. Comparing base (16b16f7) to head (2eda078).
Report is 39 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1304   +/-   ##
=======================================
  Coverage   78.88%   78.89%           
=======================================
  Files          59       59           
  Lines        7375     7376    +1     
  Branches      956      956           
=======================================
+ Hits         5818     5819    +1     
  Misses       1266     1266           
  Partials      291      291           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo tsalo deleted the fix-external-atlases branch October 24, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues noting problems and PRs fixing those problems.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using an external atlas creates an error when loading built-in xcp_d atlases.
1 participant