Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct documentation regarding Freesurfer #1277

Merged
merged 10 commits into from
Oct 3, 2024
Merged

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Oct 2, 2024

@tsalo tsalo added the documentation Improvements or additions to documentation label Oct 2, 2024
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 78.63%. Comparing base (b766391) to head (b6c0a70).
Report is 41 commits behind head on main.

Files with missing lines Patch % Lines
xcp_d/interfaces/ants.py 66.66% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1277      +/-   ##
==========================================
+ Coverage   78.55%   78.63%   +0.08%     
==========================================
  Files          59       59              
  Lines        7312     7308       -4     
  Branches     1105     1106       +1     
==========================================
+ Hits         5744     5747       +3     
+ Misses       1279     1273       -6     
+ Partials      289      288       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo
Copy link
Member Author

tsalo commented Oct 3, 2024

The last round of changes to the build image (PennLINC/xcpd_build#38) didn't fix the problem:

3dReHo: error while loading shared libraries: libgsl.so.0: cannot open shared object file: No such file or directory

@tsalo
Copy link
Member Author

tsalo commented Oct 3, 2024

Finally!!! Also, ANTS changed the filename template for CompositeTransformUtil, so I had to make a modified version of the interface instead of importing it from nipype.

@tsalo tsalo merged commit 68caadf into PennLINC:main Oct 3, 2024
20 checks passed
@tsalo tsalo deleted the doc-freesurfer branch October 3, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant