Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UKB ingression #147

Merged
merged 11 commits into from
Nov 18, 2024
Merged

Add UKB ingression #147

merged 11 commits into from
Nov 18, 2024

Conversation

smeisler
Copy link
Contributor

@smeisler smeisler commented Nov 5, 2024

at least for DSI Studio recon-specs

Changes proposed in this pull request

Update I2Q

Documentation that should be reviewed

Just the input data section of the docs.

@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 33.52%. Comparing base (1c1b0dd) to head (a7387ee).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
qsirecon/cli/parser.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
- Coverage   33.53%   33.52%   -0.01%     
==========================================
  Files          57       57              
  Lines        7117     7119       +2     
  Branches      965      967       +2     
==========================================
  Hits         2387     2387              
- Misses       4628     4630       +2     
  Partials      102      102              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@smeisler smeisler requested a review from mattcieslak November 11, 2024 14:49
@mattcieslak
Copy link
Contributor

What was the change in workbench?

@smeisler
Copy link
Contributor Author

There wasn't an update to workbench specifically. The update from testwb.0.1 to testwb.0.2 was that I updated the qsirecon_build to main and then re added the workbench.

This helps account for duplicate subject names in the case multiple sessions of a subject are ingressed. Also accounts for if the BIDS ID does not match the original input folder name.
Copy link
Contributor

@mattcieslak mattcieslak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Member

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@smeisler smeisler merged commit df45b9d into main Nov 18, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants